Skip to content

Add support to more pixel formats in vicodec

Dafna Hirschfeld linux-media outreachy 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 18 repliesIn review
  2. v33 patches 1 replySuperseded
  3. v23 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches4 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3media: vicodec: prepare support for various number of planesdrivers/media/platform/vicodec/codec-fwht.c drivers/media/platform/vicodec/codec-fwht.h drivers/media/platform/vicodec/codec-v4l2-fwht.c +2 more+32 -270 replies
2/3media: vicodec: Add support of greyscale formatdrivers/media/platform/vicodec/codec-fwht.c drivers/media/platform/vicodec/codec-fwht.h drivers/media/platform/vicodec/codec-v4l2-fwht.c +1 more+93 -400 replies
3/3media: vicodec: Add support for 4 planes formatsdrivers/media/platform/vicodec/codec-fwht.c drivers/media/platform/vicodec/codec-fwht.h drivers/media/platform/vicodec/codec-v4l2-fwht.c +1 more+59 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH vicodec v4 0/3] Add support to more pixel formats in vicodec

The new supported formats are
V4L2_PIX_FMT_GREY, V4L2_PIX_FMT_ARGB32, V4L2_PIX_FMT_ABGR32.

The returned encoded format is chaned to support various numbers of planes instead of assuming 3 planes.

The first patch adds new fields to structs.
The second patch adds support for V4L2_PIX_FMT_GREY.
The third patch adds support for V4L2_PIX_FMT_ARGB32, V4L2_PIX_FMT_ABGR32.

Changes from v3:

patch 1,3: - no change

patch 2:
- replace the 2-bit flag FWHT_FL_COMPONENTS_NUM_BIT[01] with GENMASK
- add TODO comment - handle the case where the encoded stream is different format than the decoded
- allocate maximal space for the V4L2_PIX_FMT_FWHT format

with the test 'flags & FWHT_FL_COMPONENTS_NUM_BIT[01]'

Dafna Hirschfeld (3):
media: vicodec: prepare support for various number of planes
media: vicodec: Add support of greyscale format
media: vicodec: Add support for 4 planes formats

 drivers/media/platform/vicodec/codec-fwht.c   |  73 +++++++----
 drivers/media/platform/vicodec/codec-fwht.h   |  15 ++-
 .../media/platform/vicodec/codec-v4l2-fwht.c  | 123 +++++++++++++-----
 .../media/platform/vicodec/codec-v4l2-fwht.h  |   3 +-
 drivers/media/platform/vicodec/vicodec-core.c |  35 ++++-
 5 files changed, 182 insertions(+), 67 deletions(-)
Signature · 1 line
2.17.1