Fix decoding mechanisms of the R5900
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 16 repliesIn review
- v12 patches 11 repliesSuperseded
Changes in v2 from the cover letter
- Fix HI and LO 32-bit truncation with the MIPS64 DSP ASE
- Decode special R5900 opcodes in decode_opc_special_tx79
- Guard check_insn_opc_user_only with INSN_R5900 check
- Guard check_insn with INSN_R5900 check
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | target/mips: Fix decoding mechanism of R5900 MFLO1, MFHI1, MTLO1 and MTHI1target/ | +40 | 1 reply | |
| 2/6 | target/mips: Fix decoding mechanism of R5900 DIV1 and DIVU1target/ | +59 | 0 replies | |
| 3/6 | target/mips: Fix HI[ac] and LO[ac] 32-bit truncation with MIPS64 DSP ASEtarget/ | +4 | 1 reply | |
| 4/6 | target/mips: Fix decoding mechanism of special R5900 opcodestarget/ | +50 | 12 replies | |
| 5/6 | target/mips: Guard check_insn_opc_user_only with INSN_R5900 checktarget/ | +12 | 1 reply | |
| 6/6 | target/mips: Guard check_insn with INSN_R5900 checktarget/ | +5 | 1 reply |
Reviews trailers per patch
5 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé | Aleksandar Markovic |
|---|---|---|
| 1/6 | R-b | |
| 2/6 | R-b | |
| 3/6 | ||
| 4/6 | R-b | |
| 5/6 | R-b | |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v2 0/6] Fix decoding mechanisms of the R5900
This series amends the R5900 support with the following changes:
- MFLO1, MFHI1, MTLO1 and MTHI1 are generated in gen_HILO1_tx79 instead of the generic gen_HILO.
- DIV1 and DIVU1 are generated in gen_div1_tx79 instead of the generic gen_muldiv.
- MOVN, MOVZ, MFHI, MFLO, MTHI, MTLO, MULT, MULTU, DIV, DIVU, DMULT, DMULTU, DDIV, DDIVU and JR are decoded in decode_opc_special_tx79 instead of the generic decode_opc_special_legacy.
- Guard check_insn_opc_user_only with INSN_R5900 check.
- Guard check_insn with INSN_R5900 check.
- Fix HI[ac] and LO[ac] 32-bit truncation with the MIPS64 DSP ASE.
This series has been successfully built with the 8 different build configurations
{gcc,clang} x -m64 x mips{,64}el-{linux-user,softmmu}in addition successfully completing the R5900 test suite
cd tests/tcg/mips/mipsr5900 && make check
Changes in v2:
- Fix HI and LO 32-bit truncation with the MIPS64 DSP ASE
- Decode special R5900 opcodes in decode_opc_special_tx79
- Guard check_insn_opc_user_only with INSN_R5900 check
- Guard check_insn with INSN_R5900 check
Fredrik Noring (6):
target/mips: Fix decoding mechanism of R5900 MFLO1, MFHI1, MTLO1 and MTHI1 target/mips: Fix decoding mechanism of R5900 DIV1 and DIVU1 target/mips: Fix HI[ac] and LO[ac] 32-bit truncation with MIPS64 DSP ASE target/mips: Fix decoding mechanism of special R5900 opcodes target/mips: Guard check_insn_opc_user_only with INSN_R5900 check target/mips: Guard check_insn with INSN_R5900 check
target/mips/translate.c | 229 +++++++++++++++++++++++++++++----------- 1 file changed, 170 insertions(+), 59 deletions(-)
Signature · 1 line
2.18.1