Skip to content

ICMP error handling for UDP tunnels

Stefano Brivio netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 1 replyIn review
  2. v111 patches 11 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11udp: Handle ICMP errors for tunnels with same destination port on both endpointsinclude/linux/udp.h include/net/udp_tunnel.h net/ipv4/udp.c +2 more+153 -200 replies
2/11vxlan: ICMP error lookup handlerdrivers/net/vxlan.c+29 -00 replies
3/11vxlan: Allow configuration of DF behaviourdrivers/net/vxlan.c include/net/vxlan.h include/uapi/linux/if_link.h+38 -10 replies
4/11selftests: pmtu: Introduce tests for IPv4/IPv6 over VXLAN over IPv4/IPv6tools/testing/selftests/net/pmtu.sh+125 -180 replies
5/11geneve: ICMP error lookup handlerdrivers/net/geneve.c+52 -00 replies
6/11geneve: Allow configuration of DF behaviourdrivers/net/geneve.c include/uapi/linux/if_link.h+56 -80 replies
7/11selftests: pmtu: Introduce tests for IPv4/IPv6 over GENEVE over IPv4/IPv6tools/testing/selftests/net/pmtu.sh+86 -310 replies
8/11net: Convert protocol error handlers from void to intinclude/net/icmp.h include/net/protocol.h include/net/sctp/sctp.h +24 more+177 -1210 replies
9/11udp: Support for error handlers of tunnels with arbitrary destination portinclude/net/ip6_tunnel.h include/net/ip_tunnels.h net/ipv4/udp.c +1 more+113 -350 replies
10/11fou, fou6: ICMP error handlers for FoU and GUEnet/ipv4/fou.c net/ipv4/protocol.c net/ipv6/fou6.c+143 -00 replies
11/11selftests: pmtu: Introduce FoU and GUE PMTU exceptions teststools/testing/selftests/net/pmtu.sh+179 -00 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchSabrina Dubroca
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 00/11] ICMP error handling for UDP tunnels

This series introduces ICMP error handling for UDP tunnels and encapsulations and related selftests. We need to handle ICMP errors to support PMTU discovery and route redirection -- this support is entirely missing right now:

- patch 1/11 adds a socket lookup for UDP tunnels that use, by design, the same destination port on both endpoints -- i.e. VXLAN and GENEVE
- patches 2/11 to 7/11 are specific to VxLAN and GENEVE
- patches 8/11 and 9/11 add infrastructure for lookup of encapsulations where sent packets cannot be matched via receiving socket lookup, i.e. FoU and GUE
- patches 10/11 and 11/11 are specific to FoU and GUE

v2: changes are listed in the single patches

Stefano Brivio (11):
udp: Handle ICMP errors for tunnels with same destination port on both
endpoints
vxlan: ICMP error lookup handler
vxlan: Allow configuration of DF behaviour
selftests: pmtu: Introduce tests for IPv4/IPv6 over VXLAN over

    IPv4/IPv6
  geneve: ICMP error lookup handler
  geneve: Allow configuration of DF behaviour
  selftests: pmtu: Introduce tests for IPv4/IPv6 over GENEVE over
    IPv4/IPv6

net: Convert protocol error handlers from void to int
udp: Support for error handlers of tunnels with arbitrary destination
port
fou, fou6: ICMP error handlers for FoU and GUE
selftests: pmtu: Introduce FoU and GUE PMTU exceptions tests

 drivers/net/geneve.c                | 107 +++++++-
 drivers/net/vxlan.c                 |  58 ++++-
 include/linux/udp.h                 |   1 +
 include/net/icmp.h                  |   2 +-
 include/net/ip6_tunnel.h            |   2 +
 include/net/ip_tunnels.h            |   1 +
 include/net/protocol.h              |   9 +-
 include/net/sctp/sctp.h             |   2 +-
 include/net/tcp.h                   |   2 +-
 include/net/udp.h                   |   2 +-
 include/net/udp_tunnel.h            |   3 +
 include/net/vxlan.h                 |   1 +
 include/uapi/linux/if_link.h        |  18 ++
 net/dccp/ipv4.c                     |  13 +-
 net/dccp/ipv6.c                     |  13 +-
 net/ipv4/fou.c                      |  68 +++++
 net/ipv4/gre_demux.c                |   9 +-
 net/ipv4/icmp.c                     |   6 +-
 net/ipv4/ip_gre.c                   |  48 ++--
 net/ipv4/ipip.c                     |  14 +-
 net/ipv4/protocol.c                 |   1 +
 net/ipv4/tcp_ipv4.c                 |  22 +-
 net/ipv4/tunnel4.c                  |  18 +-
 net/ipv4/udp.c                      | 121 ++++++++-
 net/ipv4/udp_impl.h                 |   2 +-
 net/ipv4/udp_tunnel.c               |   1 +
 net/ipv4/udplite.c                  |   4 +-
 net/ipv4/xfrm4_protocol.c           |  18 +-
 net/ipv6/fou6.c                     |  74 ++++++
 net/ipv6/icmp.c                     |   4 +-
 net/ipv6/ip6_gre.c                  |  18 +-
 net/ipv6/tcp_ipv6.c                 |  13 +-
 net/ipv6/tunnel6.c                  |  12 +-
 net/ipv6/udp.c                      | 146 +++++++++--
 net/ipv6/udp_impl.h                 |   4 +-
 net/ipv6/udplite.c                  |   5 +-
 net/ipv6/xfrm6_protocol.c           |  18 +-
 net/sctp/input.c                    |   5 +-
 net/sctp/ipv6.c                     |   7 +-
 tools/testing/selftests/net/pmtu.sh | 377 ++++++++++++++++++++++++++--
 40 files changed, 1083 insertions(+), 166 deletions(-)
Signature · 1 line
2.19.1