Skip to content

scsi: Mark expected switch fall-throughs

Gustavo A. R. Silva linux-scsi lkml xen-devel 1 version Applied

Status from this message: Applied to 4.21/scsi-queue.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest41 patches 100 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/41scsi: BusLogic: mark expected switch fall-throughdrivers/scsi/BusLogic.c+1 -02 replies
2/41scsi: NCR5380: Mark expected switch fall-throughdrivers/scsi/NCR5380.c+1 -22 replies
3/41scsi: aacraid: aachba: Mark expected switch fall-throughsdrivers/scsi/aacraid/aachba.c+4 -12 replies
4/41scsi: aacraid: linit: Mark expected switch fall-throughdrivers/scsi/aacraid/linit.c+1 -02 replies
5/41scsi: aic7xxx: aic79xx: mark expected switch fall-throughdrivers/scsi/aic7xxx/aic79xx_core.c+9 -54 replies
6/41scsi: aic7xxx: mark expected switch fall-throughsdrivers/scsi/aic7xxx/aic7xxx_core.c+9 -32 replies
7/41scsi: be2iscsi: be_iscsi: Mark expected switch fall-throughdrivers/scsi/be2iscsi/be_iscsi.c+1 -02 replies
8/41scsi: be2iscsi: be_main: Mark expected switch fall-throughdrivers/scsi/be2iscsi/be_main.c+1 -02 replies
9/41scsi: bfa: bfa_fcpim: Mark expected switch fall-throughsdrivers/scsi/bfa/bfa_fcpim.c+3 -32 replies
10/41scsi: bfa: bfa_fcs_lport: Mark expected switch fall-throughsdrivers/scsi/bfa/bfa_fcs_lport.c+2 -64 replies
11/41scsi: bfa: bfa_fcs_rport: Mark expected switch fall-throughsdrivers/scsi/bfa/bfa_fcs_rport.c+7 -123 replies
12/41scsi: bfa: bfa_ioc: Mark expected switch fall-throughsdrivers/scsi/bfa/bfa_ioc.c+3 -63 replies
13/41scsi: csiostor: csio_wr: mark expected switch fall-throughdrivers/scsi/csiostor/csio_wr.c+1 -02 replies
14/41scsi: esas2r: esas2r_init: mark expected switch fall-throughsdrivers/scsi/esas2r/esas2r_init.c+2 -14 replies
15/41scsi: hpsa: mark expected switch fall-throughsdrivers/scsi/hpsa.c+5 -02 replies
16/41scsi: imm: mark expected switch fall-throughsdrivers/scsi/imm.c+17 -162 replies
17/41scsi: isci: phy: Mark expected switch fall-throughdrivers/scsi/isci/phy.c+1 -01 reply
18/41scsi: isci: remote_device: Mark expected switch fall-throughsdrivers/scsi/isci/remote_device.c+2 -21 reply
19/41scsi: isci: remote_node_context: mark expected switch fall-throughsdrivers/scsi/isci/remote_node_context.c+2 -21 reply
20/41scsi: isci: request: mark expected switch fall-throughdrivers/scsi/isci/request.c+1 -11 reply
21/41scsi: libfc: fc_rport: Mark expected switch fall-throughdrivers/scsi/libfc/fc_rport.c+1 -02 replies
22/41scsi: lpfc: lpfc_ct: Mark expected switch fall-throughsdrivers/scsi/lpfc/lpfc_ct.c+2 -02 replies
23/41scsi: lpfc: lpfc_els: Mark expected switch fall-throughsdrivers/scsi/lpfc/lpfc_els.c+1 -02 replies
24/41scsi: lpfc: lpfc_hbadisc: Mark expected switch fall-throughsdrivers/scsi/lpfc/lpfc_hbadisc.c+3 -12 replies
25/41scsi: lpfc: lpfc_nportdisc: Mark expected switch fall-throughdrivers/scsi/lpfc/lpfc_nportdisc.c+1 -01 reply
26/41scsi: lpfc: lpfc_nvme: Mark expected switch fall-throughdrivers/scsi/lpfc/lpfc_nvme.c+1 -02 replies
27/41scsi: lpfc: lpfc_scsi: Mark expected switch fall-throughsdrivers/scsi/lpfc/lpfc_scsi.c+4 -42 replies
28/41scsi: lpfc: lpfc_sli: Mark expected switch fall-throughsdrivers/scsi/lpfc/lpfc_sli.c+11 -92 replies
29/41scsi: megaraid: megaraid_sas_base: Mark expected switch fall-throughdrivers/scsi/megaraid/megaraid_sas_base.c+1 -02 replies
30/41scsi: megaraid_sas_fusion: Mark expected switch fall-throughdrivers/scsi/megaraid/megaraid_sas_fusion.c+1 -12 replies
31/41scsi: mpt3sas: mpt3sas_scsih: Mark expected switch fall-throughdrivers/scsi/mpt3sas/mpt3sas_scsih.c+1 -03 replies
32/41scsi: myrb: Mark expected switch fall-throughsdrivers/scsi/myrb.c+3 -03 replies
33/41scsi: osd: osd_initiator: mark expected switch fall-throughsdrivers/scsi/osd/osd_initiator.c+2 -14 replies
34/41scsi: osst: mark expected switch fall-throughsdrivers/scsi/osst.c+6 -02 replies
35/41scsi: ppa: mark expected switch fall-throughdrivers/scsi/ppa.c+1 -02 replies
36/41scsi: qla4xxx: ql4_os: mark expected switch fall-throughdrivers/scsi/qla4xxx/ql4_os.c+1 -13 replies
37/41scsi: st: mark expected switch fall-throughsdrivers/scsi/st.c+4 -02 replies
38/41scsi: sym53c8xx_2: sym_hipd: mark expected switch fall-throughsdrivers/scsi/sym53c8xx_2/sym_hipd.c+2 -02 replies
39/41scsi: sym53c8xx_2: sym_nvram: Mark expected switch fall-throughdrivers/scsi/sym53c8xx_2/sym_nvram.c+1 -02 replies
40/41scsi: ufs: ufshcd: mark expected switch fall-throughsdrivers/scsi/ufs/ufshcd.c+3 -01 reply
41/41scsi: xen-scsifront: mark expected switch fall-throughdrivers/scsi/xen-scsifront.c+1 -14 replies
41/41scsi: xen-scsifront: mark expected switch fall-throughdrivers/scsi/xen-scsifront.c+1 -10 replies

Reviews trailers per patch

16 of 42 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJuergen GrossSumit SaxenaJohannes ThumshirnDon BraceDave CarrollKhalid AzizBoaz HarroshHannes ReineckeArtur PaszkiewiczNilesh JavaliBradley GroveSudarsana Kalluru
SeriesA-b A-b A-b A-b
1/41A-b
2/41
3/41R-b
4/41R-b
5/41R-b
6/41
7/41
8/41
9/41
10/41A-b
11/41A-b
12/41A-b
13/41
14/41A-b
15/41A-b
16/41
17/41
18/41
19/41
20/41
21/41A-b
22/41
23/41
24/41
25/41
26/41
27/41
28/41
29/41A-b
30/41A-b
31/41
32/41R-b
33/41ACK-by
34/41
35/41
36/41A-b
37/41
38/41
39/41
40/41
41/41R-b R-b
41/41R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 12 reviewers.

Read the v1 thread

Cover letter [PATCH 00/41] scsi: Mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, this patchset aims to mark switch cases where we are expecting to fall through.

I reviewed case by case and concluded that each of them is an intentional fall-through. However, it doesn't hurt that the maintainers and supporters of each driver take a look. :)

Each commit log contains the particular details for the changes in the corresponding file.

This series fix a total of 110 of the following type of warnings in drivers/scsi:

drivers/scsi/aic7xxx/aic7xxx_core.c:4921:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
ahc_dma_tag_destroy(ahc, scb_data->sg_dmat);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/aic7xxx/aic7xxx_core.c:4923:2: note: here
case 6:
^~~~

Thanks!

Gustavo A. R. Silva (41):
scsi: BusLogic: mark expected switch fall-through
scsi: NCR5380: Mark expected switch fall-through
scsi: aacraid: aachba: Mark expected switch fall-throughs
scsi: aacraid: linit: Mark expected switch fall-through
scsi: aic7xxx: aic79xx: mark expected switch fall-through
scsi: aic7xxx: mark expected switch fall-throughs
scsi: be2iscsi: be_iscsi: Mark expected switch fall-through
scsi: be2iscsi: be_main: Mark expected switch fall-through
scsi: bfa: bfa_fcpim: Mark expected switch fall-throughs
scsi: bfa: bfa_fcs_lport: Mark expected switch fall-throughs
scsi: bfa: bfa_fcs_rport: Mark expected switch fall-throughs
scsi: bfa: bfa_ioc: Mark expected switch fall-throughs
scsi: csiostor: csio_wr: mark expected switch fall-through
scsi: esas2r: esas2r_init: mark expected switch fall-throughs
scsi: hpsa: mark expected switch fall-throughs
scsi: imm: mark expected switch fall-throughs
scsi: isci: phy: Mark expected switch fall-through
scsi: isci: remote_device: Mark expected switch fall-throughs
scsi: isci: remote_node_context: mark expected switch fall-throughs
scsi: isci: request: mark expected switch fall-through
scsi: libfc: fc_rport: Mark expected switch fall-through
scsi: lpfc: lpfc_ct: Mark expected switch fall-throughs
scsi: lpfc: lpfc_els: Mark expected switch fall-throughs
scsi: lpfc: lpfc_hbadisc: Mark expected switch fall-throughs
scsi: lpfc: lpfc_nportdisc: Mark expected switch fall-through
scsi: lpfc: lpfc_nvme: Mark expected switch fall-through
scsi: lpfc: lpfc_scsi: Mark expected switch fall-throughs
scsi: lpfc: lpfc_sli: Mark expected switch fall-throughs
scsi: megaraid: megaraid_sas_base: Mark expected switch fall-through
scsi: megaraid_sas_fusion: Mark expected switch fall-through
scsi: mpt3sas: mpt3sas_scsih: Mark expected switch fall-through
scsi: myrb: Mark expected switch fall-throughs
scsi: osd: osd_initiator: mark expected switch fall-throughs
scsi: osst: mark expected switch fall-throughs
scsi: ppa: mark expected switch fall-through
scsi: qla4xxx: ql4_os: mark expected switch fall-through
scsi: st: mark expected switch fall-throughs
scsi: sym53c8xx_2: sym_hipd: mark expected switch fall-throughs
scsi: sym53c8xx_2: sym_nvram: Mark expected switch fall-through
scsi: ufs: ufshcd: mark expected switch fall-throughs
scsi: xen-scsifront: mark expected switch fall-through

 drivers/scsi/BusLogic.c                     |  1 +
 drivers/scsi/NCR5380.c                      |  3 +-
 drivers/scsi/aacraid/aachba.c               |  5 +++-
 drivers/scsi/aacraid/linit.c                |  1 +
 drivers/scsi/aic7xxx/aic79xx_core.c         | 14 +++++----
 drivers/scsi/aic7xxx/aic7xxx_core.c         | 12 ++++++--
 drivers/scsi/be2iscsi/be_iscsi.c            |  1 +
 drivers/scsi/be2iscsi/be_main.c             |  1 +
 drivers/scsi/bfa/bfa_fcpim.c                |  6 ++--
 drivers/scsi/bfa/bfa_fcs_lport.c            |  8 ++---
 drivers/scsi/bfa/bfa_fcs_rport.c            | 19 +++++-------
 drivers/scsi/bfa/bfa_ioc.c                  |  9 ++----
 drivers/scsi/csiostor/csio_wr.c             |  1 +
 drivers/scsi/esas2r/esas2r_init.c           |  3 +-
 drivers/scsi/hpsa.c                         |  5 ++++
 drivers/scsi/imm.c                          | 33 +++++++++++----------
 drivers/scsi/isci/phy.c                     |  1 +
 drivers/scsi/isci/remote_device.c           |  4 +--
 drivers/scsi/isci/remote_node_context.c     |  4 +--
 drivers/scsi/isci/request.c                 |  2 +-
 drivers/scsi/libfc/fc_rport.c               |  1 +
 drivers/scsi/lpfc/lpfc_ct.c                 |  2 ++
 drivers/scsi/lpfc/lpfc_els.c                |  1 +
 drivers/scsi/lpfc/lpfc_hbadisc.c            |  4 ++-
 drivers/scsi/lpfc/lpfc_nportdisc.c          |  1 +
 drivers/scsi/lpfc/lpfc_nvme.c               |  1 +
 drivers/scsi/lpfc/lpfc_scsi.c               |  8 ++---
 drivers/scsi/lpfc/lpfc_sli.c                | 20 +++++++------
 drivers/scsi/megaraid/megaraid_sas_base.c   |  1 +
 drivers/scsi/megaraid/megaraid_sas_fusion.c |  2 +-
 drivers/scsi/mpt3sas/mpt3sas_scsih.c        |  1 +
 drivers/scsi/myrb.c                         |  3 ++
 drivers/scsi/osd/osd_initiator.c            |  3 +-
 drivers/scsi/osst.c                         |  6 ++++
 drivers/scsi/ppa.c                          |  1 +
 drivers/scsi/qla4xxx/ql4_os.c               |  2 +-
 drivers/scsi/st.c                           |  4 +++
 drivers/scsi/sym53c8xx_2/sym_hipd.c         |  2 ++
 drivers/scsi/sym53c8xx_2/sym_nvram.c        |  1 +
 drivers/scsi/ufs/ufshcd.c                   |  3 ++
 drivers/scsi/xen-scsifront.c                |  2 +-
 41 files changed, 124 insertions(+), 78 deletions(-)
Signature · 7 lines
2.17.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel