Skip to content

dma-debug cleanup and dynamic allocation

Robin Murphy linux-iommu lkml 3 versions – Applied

Status from this message: Thanks, applied to dma-mapping for-next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 3 repliesApplied
  2. v28 patches 10 repliesSuperseded
  3. v14 patches 15 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/7dma-debug: Use pr_fmt()kernel/dma/debug.c+38 -360 replies
2/7dma-debug: Expose nr_total_entries in debugfsDocumentation/DMA-API.txt kernel/dma/debug.c+10 -00 replies
3/7dma-debug: Dynamically expand the dma_debug_entry poolDocumentation/DMA-API.txt kernel/dma/debug.c+46 -440 replies
4/7dma-debug: Make leak-like behaviour apparentDocumentation/DMA-API.txt kernel/dma/debug.c+18 -10 replies
5/7x86/dma/amd-gart: Stop resizing dma_debug_entry poolDocumentation/x86/x86_64/boot-options.txt arch/x86/kernel/amd_gart_64.c+1 -271 reply
6/7dma/debug: Remove dma_debug_resize_entries()include/linux/dma-debug.h kernel/dma/debug.c+0 -530 replies
7/7dma-debug: Batch dma_debug_entry allocationDocumentation/DMA-API.txt kernel/dma/debug.c+24 -300 replies

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigQian CaiThomas Gleixner
SeriesT-b
1/7R-b
2/7R-b
3/7
4/7R-b
5/7R-b A-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/7] dma-debug cleanup and dynamic allocation

Hi all,

Here's some assorted cleanup and improvements to dma-debug which grew out of the problem that certain drivers use very large numbers of DMA mappings, and knowing when to override "dma_debug_entries=..." and what value to override it with can be a less-than-obvious task for users.

The main part is patch #4, wherein we make dma-debug clever enough to allocate more entries dynamically if needed, such that the preallocation value becomes more of a quality-of-life option than a necessity. Patches #5 and #6 do some cruft-removal to allow patch #7 to make the allocation behaviour more efficient in general.

Patches #1, #2 and #4 are some other cleanup and handy features which fell out of the discussion/development.

Robin.

Robin Murphy (7):
dma-debug: Use pr_fmt()
dma-debug: Expose nr_total_entries in debugfs
dma-debug: Dynamically expand the dma_debug_entry pool
dma-debug: Make leak-like behaviour apparent x86/dma/amd-gart: Stop resizing dma_debug_entry pool dma/debug: Remove dma_debug_resize_entries()
dma-debug: Batch dma_debug_entry allocation

 Documentation/DMA-API.txt                 |  20 +-
 Documentation/x86/x86_64/boot-options.txt |   5 +-
 arch/x86/kernel/amd_gart_64.c             |  23 ---
 include/linux/dma-debug.h                 |   7 -
 kernel/dma/debug.c                        | 217 ++++++++++------------
 5 files changed, 109 insertions(+), 163 deletions(-)
Signature · 1 line
2.19.1.dirty