Skip to content

core/sdk: fix relative symlinks in generated tarball (branch yem/sdk)

Yann E. MORIN buildroot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2core: make symlinks relative when preparing the SDKMakefile support/scripts/fix-symlinks+54 -01 reply
2/2core/sdk: don't mangle symlinks with '.' or '..' at startMakefile+2 -21 reply
2/2core/sdk: don't mangle symlinks with '.' or '..' at start+0 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJoel Carlson
1/2R-b T-b
2/2R-b T-b
2/2R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Buildroot] [PATCH 0/2] core/sdk: fix relative symlinks in generated tarball (branch yem/sdk)

Hello All!

This two-patch series is my counter-proposal to Joel's path to try and fix the issue:

    https://patchwork.ozlabs.org/patch/1009168/

The first patch fixes the absolute symlinks, that were so far not accounted for at all. A new helper scripts changes them into relative symlinks.

The second patch is the actual fix to the issue Joel's patch was trying to solve. I believe it is a better and simpler solution, although I have to admit the patsubst trickery is not obvious.

Regards,
Yann E. MORIN.

The following changes since commit acb89c8d93952468fc9e24c7ddd9e361b8108e07

.gitlab-ci.yml: regenerate after prosody tests addition (2018-12-06 23:15:20 +0100)

are available in the git repository at:

git://git.buildroot.org/~ymorin/git/buildroot.git

for you to fetch changes up to 6ce3997e4824d41b50e13b8554e9f7e59e63a8af

core/sdk: don't mangle symlinks with '.' or '..' at start (2018-12-07 18:59:41 +0100)

----------------------------------------------------------------
Joel Carlson (1):
core/sdk: don't mangle symlinks with '.' or '..' at start

Yann E. MORIN (1):
core: make symlinks relative when preparing the SDK

 Makefile                     |  5 +++--
 support/scripts/fix-symlinks | 53 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 56 insertions(+), 2 deletions(-)
 create mode 100755 support/scripts/fix-symlinks
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'