Skip to content

vxlan: Various fixes

Petr Machata netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 1 replyIn review
  2. v24 patches 6 repliesSuperseded
  3. v15 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- Patch #2:
- Reuse the same errout block for both cleanup paths. Use a bool to decide whether the unregister_netdevice() call should be made.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4vxlan: Unmark offloaded bit on replaced FDB entriesdrivers/net/vxlan.c+1 -00 replies
2/4vxlan: Fix error path in __vxlan_dev_create()drivers/net/vxlan.c+10 -30 replies
3/4vxlan: changelink: Fix handling of default remotesdrivers/net/vxlan.c+3 -40 replies
4/4selftests: net: Add test_vxlan_fdb_changelink.shtools/testing/selftests/net/Makefile tools/testing/selftests/net/test_vxlan_fdb_changelink.sh+30 -00 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchRoopa Prabhu
1/4
2/4
3/4A-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net v3 0/4] vxlan: Various fixes

This patch set contains three fixes for the vxlan driver.

Patch #1 fixes handling of offload mark on replaced VXLAN FDB entries. A way to trigger this is to replace the FDB entry with one that can not be offloaded. A future patch set should make it possible to veto such FDB changes. However the FDB might still fail to be offloaded due to another issue, and the offload mark should reflect that.

Patch #2 fixes problems in __vxlan_dev_create() when a call to rtnl_configure_link() fails. These failures would be tricky to hit on a real system, the most likely vector is through an error in vxlan_open(). However, with the abovementioned vetoing patchset, vetoing the created entry would trigger the same problems (and be easier to reproduce).

Patch #3 fixes a problem in vxlan_changelink(). In situations where the default remote configured in the FDB table (if any) does not exactly match the remote address configured at the VXLAN device, changing the remote address breaks the default FDB entry. Patch #4 is then a self test for this issue.

v3:
- Patch #2:
- Reuse the same errout block for both cleanup paths. Use a bool to decide whether the unregister_netdevice() call should be made.

v2:
- Drop former patch #3
- Patch #2:
- Delete the default entry before calling unregister_netdevice(). That takes care of former patch #3, hence tweak the commit message to mention that problem as well.

Petr Machata (4):
vxlan: Unmark offloaded bit on replaced FDB entries
vxlan: Fix error path in __vxlan_dev_create()
vxlan: changelink: Fix handling of default remotes
selftests: net: Add test_vxlan_fdb_changelink.sh

 drivers/net/vxlan.c                                | 21 ++++++++++------
 tools/testing/selftests/net/Makefile               |  1 +
 .../selftests/net/test_vxlan_fdb_changelink.sh     | 29 ++++++++++++++++++++++
 3 files changed, 44 insertions(+), 7 deletions(-)
 create mode 100755 tools/testing/selftests/net/test_vxlan_fdb_changelink.sh
Signature · 1 line
2.4.11