tracing: Hist trigger var-ref cleanup and comments
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 22 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | tracing: Remove unnecessary hist trigger struct fieldkernel/ | +0 | 0 replies | |
| 2/7 | tracing: Change strlen to sizeof for hist trigger static stringskernel/ | +19 | 14 replies | |
| 3/7 | tracing: Use var_refs[] for hist trigger reference checkingkernel/ | +7 | 5 replies | |
| 4/7 | tracing: Remove open-coding of hist trigger var_ref managementkernel/ | +75 | 0 replies | |
| 5/7 | tracing: Use hist trigger's var_ref array to destroy var_refskernel/ | +19 | 0 replies | |
| 6/7 | tracing: Remove hist trigger synth_var_refskernel/ | +0 | 0 replies | |
| 7/7 | tracing: Add hist trigger comments for variable-related fieldskernel/ | +36 | 0 replies |
Reviews trailers per patch
1 of 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Namhyung Kim | Masami Hiramatsu | Steve Rostedt |
|---|---|---|---|
| Series | A-b | R-b | |
| 1/7 | |||
| 2/7 | Idea-and-macro-by | ||
| 3/7 | R-b | ||
| 4/7 | |||
| 5/7 | |||
| 6/7 | |||
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/7] tracing: Hist trigger var-ref cleanup and comments
From: Tom Zanussi <[email protected]>
Hi,
This patchset is a standalone series broken out of the v8 version of the 'tracing: Hist trigger snapshot and onchange additions' patchset.
It's a series of changes resulting from some suggestions from Namhyung for making the variable-reference handling code more understandable through some refactoring and comments.
It also added a new patch changing all strlen() to sizeof() for string constants, in trace_events_hist.c
Also, in the 'tracing: Remove open-coding of hist trigger var_ref management' patch, in create_var_ref(), moved the saving of ref_field and update of ref_field->var_ref_idx into the 'if' as pointed out by Dan Carpenter/smatch 0-day robot.
It doesn't introduce any functional changes and can be applied independently of the other patchset.
Tom
The following changes since commit 5d6ddf6acce68d1290112cb08b12fd78b201e7d5:
arm64: Use ftrace_graph_get_ret_stack() instead of curr_ret_stack (2018-12-08 22:21:31 -0500)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/hist-var-ref-cleanup-v1
Tom Zanussi (7):
tracing: Remove unnecessary hist trigger struct field
tracing: Change strlen to sizeof for hist trigger static strings
tracing: Use var_refs[] for hist trigger reference checking
tracing: Remove open-coding of hist trigger var_ref management
tracing: Use hist trigger's var_ref array to destroy var_refs
tracing: Remove hist trigger synth_var_refs
tracing: Add hist trigger comments for variable-related fields
kernel/trace/trace_events_hist.c | 267 +++++++++++++++++++++++---------------- 1 file changed, 156 insertions(+), 111 deletions(-)
Signature · 1 line
2.14.1