Skip to content

Clean up rte_option

Gaetan Rivet dpdk-dev 1 version Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/8option: use bare option string as namelib/librte_eal/common/rte_option.c lib/librte_telemetry/rte_telemetry.c+6 -20 replies
2/8option: do not use static iteratorlib/librte_eal/common/rte_option.c+6 -20 replies
3/8option: add usage stringlib/librte_eal/common/eal_common_options.c lib/librte_eal/common/eal_private.h lib/librte_eal/common/include/rte_option.h +2 more+27 -00 replies
4/8option: rename name fieldlib/librte_eal/common/include/rte_option.h lib/librte_eal/common/rte_option.c lib/librte_telemetry/rte_telemetry.c+6 -60 replies
5/8option: check against common option on registerlib/librte_eal/common/rte_option.c+14 -00 replies
6/8option: fix log level of error in registerlib/librte_eal/common/rte_option.c+1 -10 replies
7/8option: improve library documentationlib/librte_eal/common/include/rte_option.h+6 -20 replies
8/8option: return an error when register faillib/librte_eal/common/include/rte_option.h lib/librte_eal/common/rte_option.c+10 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/8] Clean up rte_option

rte_option lib might benefit from a few improvements.

Overview:

- list registered options on /rte/app --help
- check duplicates within base EAL options
- rename some fields to be closer to standard struct option and just cleaner overall.
- fix some strange code (static iterator?)
- fix doc, improve API a little...

Gaetan Rivet (8):
option: use bare option string as name
option: do not use static iterator
option: add usage string
option: rename name field
option: check against common option on register
option: fix log level of error in register
option: improve library documentation
option: return an error when register fail

 lib/librte_eal/common/eal_common_options.c |  1 +
 lib/librte_eal/common/eal_private.h        |  7 +++
 lib/librte_eal/common/include/rte_option.h | 17 +++++--
 lib/librte_eal/common/rte_option.c         | 57 +++++++++++++++++++---
 lib/librte_telemetry/rte_telemetry.c       |  3 +-
 5 files changed, 72 insertions(+), 13 deletions(-)
Signature · 1 line
2.19.1