RFC drm/i915: from module params to device params
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest11 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | drm/i915: add a helper to make a copy of i915_paramsdrivers/ drivers/ drivers/ | +16 | 0 replies | |
| 2/11 | drm/i915: add a helper to free the members of i915_paramsdrivers/ drivers/ drivers/ | +18 | 0 replies | |
| 3/11 | drm/i915/uc: add dev_priv parameter to intel_uc_is_using_* functionsdrivers/ drivers/ drivers/ +1 more | +13 | 1 reply | |
| 4/11 | drm/i915/params: set i915.enable_hangcheck permissions to 0600drivers/ | +1 | 0 replies | |
| 5/11 | drm/i915: move load failure injection to selftestsdrivers/ drivers/ drivers/ +3 more | +36 | 0 replies | |
| 6/11 | drm/i915/params: document I915_PARAMS_FOR_EACH()drivers/ | +9 | 0 replies | |
| 7/11 | drm/i915/params: add i915 parameters to debugfsdrivers/ drivers/ drivers/ | +233 | 0 replies | |
| 8/11 | drm/i915/debugfs: support bool values for int and uint paramsdrivers/ | +14 | 1 reply | |
| 8/11 | drm/i915/params: support bool values for int and uint paramsdrivers/ | +14 | 0 replies | |
| 9/11 | drm/i915/params: prevent changing module params runtimedrivers/ | +25 | 0 replies | |
| 10/11 | drm/i915/params: switch to device specific parametersdrivers/ drivers/ drivers/ +24 more | +131 | 0 replies | |
| 11/11 | drm/i915/params: hide i915_modparams within i915_params.cdrivers/ drivers/ drivers/ +2 more | +28 | 0 replies |
Reviews trailers per patch
1 of 12 patches has a Reviewed-by or Acked-by.
| Patch | Chris Wilson |
|---|---|
| 1/11 | R-b |
| 2/11 | |
| 3/11 | |
| 4/11 | |
| 5/11 | |
| 6/11 | |
| 7/11 | |
| 8/11 | |
| 8/11 | |
| 9/11 | |
| 10/11 | |
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH 00/11] drm/i915: from module params to device params
Season's greetings!
This series migrates module parameters to per-device parameters in drm_i915_private, accessible via debugfs.
Patches 1-6 are fairly straightforward prep work to make the rest easier. After initial reviews I'll probably submit them separately.
Patches 7-8 add debugfs access to the current module parameters. They work simultaneously with the module parameter sysfs access.
It is expected that at this point we'll have a transition period, as IGT needs to be switched over to using the debugfs, but we don't want to have a flag day.
Patch 9 removes module parameter sysfs write access, leaving debugfs the only interface to changing module parameters runtime. This breaks IGT.
Patch 10 copies module parameters to dev_priv, and starts using them as device specific parameters from there, leaving module parameters merely initial/default values for the device parameters.
Patch 11 makes i915_modparams static to avoid accidental module param use where device parameters should be used.
The series is thoroughly untested, and CI will greet it with nice red christmas colors, bringing comfort and joy to us all.
Cheers,
Jani.
Jani Nikula (11):
drm/i915: add a helper to make a copy of i915_params drm/i915: add a helper to free the members of i915_params drm/i915/uc: add dev_priv parameter to intel_uc_is_using_* functions drm/i915/params: set i915.enable_hangcheck permissions to 0600 drm/i915: move load failure injection to selftests drm/i915/params: document I915_PARAMS_FOR_EACH() drm/i915/params: add i915 parameters to debugfs drm/i915/params: support bool values for int and uint params drm/i915/params: prevent changing module params runtime drm/i915/params: switch to device specific parameters drm/i915/params: hide i915_modparams within i915_params.c
drivers/gpu/drm/i915/i915_debugfs.c | 217 ++++++++++++++++++++++- drivers/gpu/drm/i915/i915_drv.c | 37 +--- drivers/gpu/drm/i915/i915_drv.h | 28 +-- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +- drivers/gpu/drm/i915/i915_gpu_error.c | 22 +-- drivers/gpu/drm/i915/i915_params.c | 97 +++++++--- drivers/gpu/drm/i915/i915_params.h | 84 +++++---- drivers/gpu/drm/i915/i915_pci.c | 6 +- drivers/gpu/drm/i915/i915_selftest.h | 10 ++ drivers/gpu/drm/i915/intel_bios.c | 6 +- drivers/gpu/drm/i915/intel_crt.c | 4 +- drivers/gpu/drm/i915/intel_csr.c | 6 +- drivers/gpu/drm/i915/intel_device_info.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 10 +- drivers/gpu/drm/i915/intel_dp.c | 11 +- drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 3 +- drivers/gpu/drm/i915/intel_fbc.c | 12 +- drivers/gpu/drm/i915/intel_guc_fw.c | 4 +- drivers/gpu/drm/i915/intel_guc_log.c | 3 +- drivers/gpu/drm/i915/intel_gvt.c | 8 +- drivers/gpu/drm/i915/intel_hangcheck.c | 2 +- drivers/gpu/drm/i915/intel_huc_fw.c | 4 +- drivers/gpu/drm/i915/intel_lvds.c | 4 +- drivers/gpu/drm/i915/intel_opregion.c | 2 +- drivers/gpu/drm/i915/intel_panel.c | 4 +- drivers/gpu/drm/i915/intel_psr.c | 14 +- drivers/gpu/drm/i915/intel_runtime_pm.c | 14 +- drivers/gpu/drm/i915/intel_uc.c | 66 ++++--- drivers/gpu/drm/i915/intel_uc.h | 21 +-- drivers/gpu/drm/i915/intel_uncore.c | 18 +- drivers/gpu/drm/i915/intel_wopcm.c | 2 +- drivers/gpu/drm/i915/selftests/i915_selftest.c | 26 +++ drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 4 +- 33 files changed, 515 insertions(+), 238 deletions(-)
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx