Skip to content

MDSv4 2

Andi Kleen historical-speck 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest28 patches 15 repliesIn review

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/28MDSv4 3arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/msr-index.h arch/x86/kernel/cpu/common.c+17 -01 reply
2/28MDSv4 22Documentation/admin-guide/kernel-parameters.txt arch/x86/include/asm/cpufeatures.h arch/x86/kernel/cpu/bugs.c+13 -00 replies
3/28MDSv4 20arch/x86/entry/common.c arch/x86/include/asm/clearcpu.h arch/x86/include/asm/thread_info.h+32 -13 replies
4/28MDSv4 8Documentation/admin-guide/kernel-parameters.txt arch/x86/entry/common.c arch/x86/include/asm/clearcpu.h +1 more+17 -10 replies
5/28MDSv4 10arch/x86/include/asm/clearcpu.h arch/x86/kernel/acpi/cstate.c arch/x86/kernel/kvm.c +6 more+43 -04 replies
6/28MDSv4 11Documentation/ABI/testing/sysfs-devices-system-cpu arch/x86/kernel/cpu/bugs.c drivers/base/cpu.c+25 -02 replies
7/28MDSv4 0arch/x86/entry/entry_64.S arch/x86/include/asm/clearcpu.h+23 -03 replies
8/28MDSv4 19arch/x86/entry/entry_32.S+6 -00 replies
9/28MDSv4 16arch/x86/kvm/cpuid.c+2 -10 replies
10/28MDSv4 24Documentation/clearcpu.txt+173 -01 reply
11/28MDSv4 21Documentation/admin-guide/mds.rst+108 -00 replies
12/28MDSv4 25arch/Kconfig arch/x86/Kconfig arch/x86/include/asm/clearcpu.h +1 more+45 -00 replies
13/28MDSv4 4arch/x86/kernel/process.h+27 -00 replies
14/28MDSv4 17arch/x86/include/asm/clearcpu.h arch/x86/include/asm/trace/clearcpu.h arch/x86/kernel/cpu/bugs.c+78 -20 replies
15/28MDSv4 9kernel/sched/core.c+9 -00 replies
16/28MDSv4 6lib/string.c mm/slab_common.c+10 -10 replies
17/28MDSv4 18include/linux/interrupt.h kernel/irq/handle.c kernel/irq/manage.c+11 -00 replies
18/28MDSv4 26include/linux/hrtimer.h include/linux/timer.h kernel/time/hrtimer.c +1 more+23 -30 replies
19/28MDSv4 14include/linux/interrupt.h kernel/softirq.c+34 -70 replies
20/28MDSv4 23include/linux/irq_poll.h lib/irq_poll.c+18 -20 replies
21/28MDSv4 15arch/x86/include/asm/io.h include/asm-generic/io.h+6 -00 replies
22/28MDSv4 5kernel/dma/swiotlb.c+2 -00 replies
23/28MDSv4 13include/linux/skbuff.h net/core/skbuff.c+28 -00 replies
24/28MDSv4 28net/ipv4/tcp_output.c+3 -20 replies
25/28MDSv4 1kernel/events/core.c kernel/fork.c kernel/futex.c +11 more+40 -240 replies
26/28MDSv4 27drivers/ata/ahci.c drivers/ata/ahci.h drivers/ata/libahci.c+27 -170 replies
27/28MDSv4 7drivers/acpi/osl.c+2 -10 replies
28/28MDSv4 12arch/x86/include/asm/clearbpf.h include/linux/filter.h kernel/bpf/core.c+50 -20 replies

Reviews trailers per patch

None of the 28 patches has a Reviewed-by or Acked-by.

PatchNeelima Krishnan
1/28
2/28
3/28T-b
4/28
5/28
6/28
7/28
8/28
9/28T-b
10/28
11/28
12/28
13/28T-b
14/28
15/28
16/28
17/28
18/28
19/28
20/28
21/28
22/28
23/28
24/28
25/28
26/28
27/28
28/28

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [MODERATED] [PATCH v4 00/28] MDSv4 2

Here's a new version of flushing CPU buffers for group 4.

This mainly covers single thread, not SMT (except for the idle case).

I lumped all the issues together under the Microarchitectural Data Sampling (MDS) name because they need the same mitigations,a and it doesn't seem worth duplicating the sysfs files and bug entries.

This version drops support for software sequences, and also does VERW unconditionally unless disabled.

This version implements Linus' suggestion to only clear the CPU buffer when needed. The patch kit is now a lot more complicated:
different subsystems determine if they might touch other user's or sensitive data and schedule a cpu clear on next kernel exit.

Generally process context doesn't clear (unless it is cryptographic or does context switches), and interrupt context schedules a clear. There are some exceptions to these rules.

For details on the security model see the Documentation/clearcpu.txt file. In my tests the number of clears is much lower now.

For most benchmarks we tried the difference is in the noise level now. ebizzy and loopback apache both show about 1.7% degradation.

It makes various assumptions on how kernel code behaves. I did some auditing, but wasn't able to do it for everything. Please double check the assumptions laid out in the document.

Likely a lot more interrupt and timer handlers (and tasklets and irq poll handlers) could be white listed to not need clear, but I only did a fairly minimum set for now that I could test.

For some of the white listed code, especially the networking and block softirqs, as well as the EBPF mitigation, some additional auditing that no rules are violated would be useful.

Some notes:
- Against 5.0-rc1

Changes against previous versions:
- Remove software sequences
- Make VERW unconditional
- Improved documentation
- Some other minor changes

Changes against previous versions:
- By default now flushes only when needed
- Define security model
- New administrator document
- Added mds=verw and mds=full
- Renamed mds_disable to mds=off
- KVM virtualization much improved
- Too many others to list. Most things different now.

Andi Kleen (28):
x86/speculation/mds: Add basic bug infrastructure for MDS x86/speculation/mds: Add mds=off x86/speculation/mds: Support clearing CPU data on kernel exit x86/speculation/mds: Support mds=full x86/speculation/mds: Clear CPU buffers on entering idle x86/speculation/mds: Add sysfs reporting x86/speculation/mds: Support mds=full for NMIs x86/speculation/mds: Support mds=full for 32bit NMI x86/speculation/mds: Export MD_CLEAR CPUID to KVM guests.
mds: Add documentation for clear cpu usage
mds: Add preliminary administrator documentation x86/speculation/mds: Introduce lazy_clear_cpu x86/speculation/mds: Schedule cpu clear on context switch x86/speculation/mds: Add tracing for clear_cpu
mds: Force clear cpu on kernel preemption
mds: Schedule cpu clear for memzero_explicit and kzfree
mds: Mark interrupts clear cpu, unless opted-out
mds: Clear cpu on all timers, unless the timer opts-out
mds: Clear CPU on tasklets, unless opted-out
mds: Clear CPU on irq poll, unless opted-out
mds: Clear cpu for string io/memcpy_*io in interrupts
mds: Schedule clear cpu in swiotlb
mds: Instrument skb functions to clear cpu automatically
mds: Opt out tcp tasklet to not touch user data
mds: mark kernel/* timers safe as not touching user data
mds: Mark AHCI interrupt as not needing cpu clear
mds: Mark ACPI interrupt as not needing cpu clear
mds: Mitigate BPF

 .../ABI/testing/sysfs-devices-system-cpu      |   1 +
 .../admin-guide/kernel-parameters.txt         |   8 +
 Documentation/admin-guide/mds.rst             | 108 +++++++++++
 Documentation/clearcpu.txt                    | 173 ++++++++++++++++++
 arch/Kconfig                                  |   3 +
 arch/x86/Kconfig                              |   1 +
 arch/x86/entry/common.c                       |  13 +-
 arch/x86/entry/entry_32.S                     |   6 +
 arch/x86/entry/entry_64.S                     |  12 ++
 arch/x86/include/asm/clearbpf.h               |  29 +++
 arch/x86/include/asm/clearcpu.h               |  92 ++++++++++
 arch/x86/include/asm/cpufeatures.h            |   3 +
 arch/x86/include/asm/io.h                     |   3 +
 arch/x86/include/asm/msr-index.h              |   1 +
 arch/x86/include/asm/thread_info.h            |   2 +
 arch/x86/include/asm/trace/clearcpu.h         |  27 +++
 arch/x86/kernel/acpi/cstate.c                 |   2 +
 arch/x86/kernel/cpu/bugs.c                    |  46 +++++
 arch/x86/kernel/cpu/common.c                  |  14 ++
 arch/x86/kernel/kvm.c                         |   3 +
 arch/x86/kernel/process.c                     |   5 +
 arch/x86/kernel/process.h                     |  27 +++
 arch/x86/kernel/smpboot.c                     |   3 +
 arch/x86/kvm/cpuid.c                          |   3 +-
 drivers/acpi/acpi_pad.c                       |   2 +
 drivers/acpi/osl.c                            |   3 +-
 drivers/acpi/processor_idle.c                 |   3 +
 drivers/ata/ahci.c                            |   2 +-
 drivers/ata/ahci.h                            |   2 +
 drivers/ata/libahci.c                         |  40 ++--
 drivers/base/cpu.c                            |   8 +
 drivers/idle/intel_idle.c                     |   5 +
 include/asm-generic/io.h                      |   3 +
 include/linux/clearcpu.h                      |  36 ++++
 include/linux/filter.h                        |  21 ++-
 include/linux/hrtimer.h                       |   4 +
 include/linux/interrupt.h                     |  18 +-
 include/linux/irq_poll.h                      |   2 +
 include/linux/skbuff.h                        |   2 +
 include/linux/timer.h                         |   9 +-
 kernel/bpf/core.c                             |   2 +
 kernel/dma/swiotlb.c                          |   2 +
 kernel/events/core.c                          |   6 +-
 kernel/fork.c                                 |   3 +-
 kernel/futex.c                                |   6 +-
 kernel/irq/handle.c                           |   8 +
 kernel/irq/manage.c                           |   1 +
 kernel/sched/core.c                           |  14 +-
 kernel/sched/deadline.c                       |   6 +-
 kernel/sched/fair.c                           |   7 +-
 kernel/sched/idle.c                           |   3 +-
 kernel/sched/rt.c                             |   3 +-
 kernel/softirq.c                              |  25 ++-
 kernel/time/alarmtimer.c                      |   2 +-
 kernel/time/hrtimer.c                         |  11 +-
 kernel/time/posix-timers.c                    |   6 +-
 kernel/time/sched_clock.c                     |   3 +-
 kernel/time/tick-sched.c                      |   6 +-
 kernel/time/timer.c                           |   8 +
 kernel/watchdog.c                             |   3 +-
 lib/irq_poll.c                                |  18 +-
 lib/string.c                                  |   6 +
 mm/slab_common.c                              |   5 +-
 net/core/skbuff.c                             |  26 +++
 net/ipv4/tcp_output.c                         |   5 +-
 65 files changed, 869 insertions(+), 61 deletions(-)
 create mode 100644 Documentation/admin-guide/mds.rst
 create mode 100644 Documentation/clearcpu.txt
 create mode 100644 arch/x86/include/asm/clearbpf.h
 create mode 100644 arch/x86/include/asm/clearcpu.h
 create mode 100644 arch/x86/include/asm/trace/clearcpu.h
 create mode 100644 include/linux/clearcpu.h
Signature · 1 line
2.17.2