Skip to content

RFC do not use sg if not properly supported by usb controller

Lorenzo Bianconi linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4mt76: usb: move mt76u_check_sg in usb.cdrivers/net/wireless/mediatek/mt76/mt76.h drivers/net/wireless/mediatek/mt76/mt76x0/usb.c drivers/net/wireless/mediatek/mt76/mt76x2/usb_init.c +1 more+16 -130 replies
2/4mt76: usb: do not use sg buffer for fw uploaddrivers/net/wireless/mediatek/mt76/mt76.h drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c drivers/net/wireless/mediatek/mt76/usb.c +1 more+38 -160 replies
3/4mt76: usb: use a linear buffer for tx/rx datapath if sg is not supporteddrivers/net/wireless/mediatek/mt76/usb.c+54 -330 replies
4/4mt76: usb: introduce disable_usb_sg parameterdrivers/net/wireless/mediatek/mt76/usb.c+5 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/4] do not use sg if not properly supported by usb controller

Use linear fragment and not a single usb scatter-gather buffer in mt76u {tx,rx} datapath if the usb controller has sg data length constraints. Moreover add disable_usb_sg module parameter in order to explicitly disable scatter-gather. Some users have reported sg issues on AMD IOMMU

Lorenzo Bianconi (4):
mt76: usb: move mt76u_check_sg in usb.c
mt76: usb: do not use sg buffer for fw upload
mt76: usb: use a linear buffer for tx/rx datapath if sg is not
supported
mt76: usb: introduce disable_usb_sg parameter

 drivers/net/wireless/mediatek/mt76/mt76.h     |  14 +-
 .../net/wireless/mediatek/mt76/mt76x0/usb.c   |   2 +-
 .../wireless/mediatek/mt76/mt76x02_usb_mcu.c  |   9 +-
 .../wireless/mediatek/mt76/mt76x2/usb_init.c  |   2 +-
 drivers/net/wireless/mediatek/mt76/usb.c      | 132 +++++++++++++-----
 drivers/net/wireless/mediatek/mt76/usb_mcu.c  |   5 +-
 6 files changed, 107 insertions(+), 57 deletions(-)
Signature · 1 line
2.20.1