Skip to content

iothread-related fixes for virtio-scsi

Alberto Garcia qemu-devel 1 version Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 12 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3virtio-scsi: Move BlockBackend back to the main AioContext on unplughw/scsi/virtio-scsi.c tests/qemu-iotests/240 tests/qemu-iotests/240.out +1 more+114 -00 replies
2/3scsi-disk: Acquire the AioContext in scsi_*_realize()hw/scsi/scsi-disk.c tests/qemu-iotests/240 tests/qemu-iotests/240.out+54 -30 replies
3/3virtio-scsi: Forbid devices with different iothreads sharing a blockdevhw/scsi/virtio-scsi.c tests/qemu-iotests/240 tests/qemu-iotests/240.out+49 -011 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/3] iothread-related fixes for virtio-scsi

Hi,

here are three patches with iothread-related fixes for virtio-scsi, with their test cases.

This series fixes the following bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1656276

https://bugzilla.redhat.com/show_bug.cgi?id=1662508

I also wanted to do prepare a similar one for virtio-blk but I'm unsure about how to proceed, because I'm unable to detect during realize() that the blockdev is using a different iothread. This crashes QEMU:

{ "execute": "qmp_capabilities" }
{ "execute": "blockdev-add", "arguments": {"driver": "null-co", "node-name": "hd0", "read-only": true}}
{ "execute": "object-add", "arguments": {"qom-type": "iothread", "id": "iothread0"}}
{ "execute": "object-add", "arguments": {"qom-type": "iothread", "id": "iothread1"}}
{ "execute": "device_add", "arguments": {"id": "virtio-blk0", "driver": "virtio-blk", "iothread": "iothread0", "drive": "hd0"}} { "execute": "system_reset"}
(wait for the events)
{ "execute": "device_add", "arguments": {"id": "virtio-blk1", "driver": "virtio-blk", "iothread": "iothread1", "drive": "hd0"}}

Regards,

Berto

Alberto Garcia (3):
virtio-scsi: Move BlockBackend back to the main AioContext on unplug
scsi-disk: Acquire the AioContext in scsi_*_realize()
virtio-scsi: Forbid devices with different iothreads sharing a
blockdev

 hw/scsi/scsi-disk.c        |  23 ++++++--
 hw/scsi/virtio-scsi.c      |  13 +++++
 tests/qemu-iotests/240     | 129 +++++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/240.out |  54 +++++++++++++++++++
 tests/qemu-iotests/group   |   1 +
 5 files changed, 217 insertions(+), 3 deletions(-)
 create mode 100755 tests/qemu-iotests/240
 create mode 100644 tests/qemu-iotests/240.out
Signature · 1 line
2.11.0