Skip to content

Raspberry Pi DMA fixes + cleanups

Lukas Wunner linux-rt-users 1 version Applied

Status from this message: Applied all, thanks

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest6 patches 3 repliesApplied

Changes in v2 from the cover letter

* Patch [1/6]: Rework the patch to fix a race condition which could still occur with v1, and no longer check for idleness of a channel using the ACTIVE flag in the CS register (which is unreliable), but check for a zero control block address instead.

* Patch [2/6]: If outstanding writes fail to complete on abort of a transaction, print an error message and document a possible cause in a code comment. (Stefan Wahren)

* Patch [5/6] and [6/6]: Split patch to remove dead code in two and rephrase commit subject to be less generic. (Stefan Wahren, Vinod Koul)

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6dmaengine: bcm2835: Fix interrupt race on RTdrivers/dma/bcm2835-dma.c+18 -150 replies
2/6dmaengine: bcm2835: Fix abort of transactionsdrivers/dma/bcm2835-dma.c+9 -320 replies
3/6dmaengine: bcm2835: Return void from abort of transactionsdrivers/dma/bcm2835-dma.c+2 -30 replies
4/6dmaengine: bcm2835: Enforce control block alignmentdrivers/dma/bcm2835-dma.c+5 -10 replies
5/6dmaengine: bcm2835: Drop gratuitous list deletiondrivers/dma/bcm2835-dma.c+0 -100 replies
6/6dmaengine: bcm2835: Drop outdated comment on supported transactionsdrivers/dma/bcm2835-dma.c+0 -30 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefan WahrenFlorian Kauer
SeriesT-b A-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] Raspberry Pi DMA fixes + cleanups

Two fixes and four cleanups for the Raspberry Pi DMA driver, v2.

Changes since v1:

* Patch [1/6]: Rework the patch to fix a race condition which could still occur with v1, and no longer check for idleness of a channel using the ACTIVE flag in the CS register (which is unreliable), but check for a zero control block address instead.

* Patch [2/6]: If outstanding writes fail to complete on abort of a transaction, print an error message and document a possible cause in a code comment. (Stefan Wahren)

* Patch [5/6] and [6/6]: Split patch to remove dead code in two and rephrase commit subject to be less generic. (Stefan Wahren, Vinod Koul)

Thanks,

Lukas

Lukas Wunner (6):
dmaengine: bcm2835: Fix interrupt race on RT
dmaengine: bcm2835: Fix abort of transactions
dmaengine: bcm2835: Return void from abort of transactions
dmaengine: bcm2835: Enforce control block alignment
dmaengine: bcm2835: Drop gratuitous list deletion
dmaengine: bcm2835: Drop outdated comment on supported transactions

 drivers/dma/bcm2835-dma.c | 92 +++++++++++++--------------------------
 1 file changed, 31 insertions(+), 61 deletions(-)
Signature · 1 line
2.20.1