char-socket: Fix race condition
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 11 repliesIn review
- v23 patches 5 repliesSuperseded
- v13 patches 17 repliesSuperseded
Changes in v3 from the cover letter
- Patch 3: Add tcp_chr_disconnect_locked() [Daniel]
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | main-loop: Fix GSource leak in qio_task_thread_worker()io/ | +1 | 0 replies | |
| 2/3 | main-loop: Add qemu_idle_add()include/ io/ util/ | +24 | 0 replies | |
| 3/3 | char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout()chardev/ | +21 | 2 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Daniel P. Berrangé |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v3 0/3] char-socket: Fix race condition
This fixes a race condition in which the tcp_chr_read() ioc handler can close a connection that is being written to from another thread.
Note: vhost-user-test still fails if QTEST_VHOST_USER_FIXME is set.
Berto
RFC: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01510.html
v1: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01834.html
- Fixes memory leaks and adds a qemu_idle_add() function
v2: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg06137.html
- Rebased on top of the current master (fc3dbb90f2eb069801bfb4cfe9cbc)
- Patches 1 and 2: Remove the changes in char-pty.c, they're not needed after the rebase.
- Patch 3: Fix conflicts after the rebase.
v3:
- Patch 3: Add tcp_chr_disconnect_locked() [Daniel]
Alberto Garcia (3):
main-loop: Fix GSource leak in qio_task_thread_worker()
main-loop: Add qemu_idle_add()
char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout()
chardev/char-socket.c | 25 +++++++++++++++++++++---- include/qemu/main-loop.h | 12 ++++++++++++ io/task.c | 9 +++------ util/main-loop.c | 9 +++++++++ 4 files changed, 45 insertions(+), 10 deletions(-)
Signature · 1 line
2.11.0