Skip to content

Drivers: hv: vmbus: Fix sysfs functions that display monitor id and page data

Kimberly Brown linux-hyperv lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 6 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Drivers: hv: vmbus: Change server monitor_pages index to 0drivers/hv/vmbus_drv.c+1 -11 reply
2/2Drivers: hv: vmbus: Return -EINVAL if monitor_allocated not setDocumentation/ABI/stable/sysfs-bus-vmbus drivers/hv/vmbus_drv.c+49 -317 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchStephen HemmingerMichael KelleyGreg Kroah-Hartman
1/2A-b R-b
2/2R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/2] Drivers: hv: vmbus: Fix sysfs functions that display monitor id and page data

Some of the monitor id and monitor page data sysfs files display incorrect data. This patchset provides the following changes:

1) Change the monitor_pages index in server_monitor_pending_show() to '0', which is the correct index for the server.

2) If monitor pages are not allocated to a channel, return -EINVAL when the channel's monitor id and monitor page data sysfs files are opened. The data that is currently shown in sysfs is incorrect.

Changes in v2:

Patch 1: "Change server monitor_pages index to 0"
- Added the "Acked-by" line received for v1.

Patch 2: "Return -EINVAL if monitor_allocated not set"
- Changed the return value for cases where monitor_allocated is not set to "-EINVAL" as suggested by S. Hemminger.
- Updated the commit message to provide more details about the monitor page mechanism as suggested by S. Hemminger.
- Updated the sysfs documentation to describe the new return value.

Kimberly Brown (2):
Drivers: hv: vmbus: Change server monitor_pages index to 0
Drivers: hv: vmbus: Return -EINVAL if monitor_allocated not set

 Documentation/ABI/stable/sysfs-bus-vmbus | 15 +++++++--
 drivers/hv/vmbus_drv.c                   | 39 +++++++++++++++++++++++-
 2 files changed, 50 insertions(+), 4 deletions(-)
Signature · 1 line
2.17.1