do not use sg if not properly supported by usb controller
Status from this message: Applied, thanks.
Get series with b4
b4 am [email protected]Versions newest first
Changes since RFC from the cover letter
- rebased on top of 'fix multiple issues in mt76u error path'
https://patchwork.kernel.org/cover/10804919/
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | mt76: usb: move mt76u_check_sg in usb.cdrivers/ drivers/ drivers/ +1 more | +16 | 0 replies | |
| 2/4 | mt76: usb: do not use sg buffers for mcu messagesdrivers/ drivers/ drivers/ +1 more | +36 | 0 replies | |
| 3/4 | mt76: usb: use a linear buffer for tx/rx datapath if sg is not supporteddrivers/ | +54 | 0 replies | |
| 4/4 | mt76: usb: introduce disable_usb_sg parameterdrivers/ | +5 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH RESEND 0/4] do not use sg if not properly supported by usb controller
From: Lorenzo Bianconi <[email protected]>
Use linear fragment and not a single usb scatter-gather buffer in mt76u {tx,rx} datapath if the usb controller has sg data length constraints. Moreover add disable_usb_sg module parameter in order to explicitly disable scatter-gather. SG I/O is not supported by all host drivers and some users have reported sg issues on AMD IOMMU.
This series has been tested on AMD IOMMU cpus/motherboards and on rpi3+
Changes since RFC:
- rebased on top of 'fix multiple issues in mt76u error path'
https://patchwork.kernel.org/cover/10804919/
I am resending the series since the first attempt seems to be rejected by the ML
Lorenzo Bianconi (4):
mt76: usb: move mt76u_check_sg in usb.c
mt76: usb: do not use sg buffers for mcu messages
mt76: usb: use a linear buffer for tx/rx datapath if sg is not
supported
mt76: usb: introduce disable_usb_sg parameter
drivers/net/wireless/mediatek/mt76/mt76.h | 14 +- .../net/wireless/mediatek/mt76/mt76x0/usb.c | 2 +- .../wireless/mediatek/mt76/mt76x02_usb_mcu.c | 3 +- .../wireless/mediatek/mt76/mt76x2/usb_init.c | 2 +- drivers/net/wireless/mediatek/mt76/usb.c | 133 +++++++++++++----- drivers/net/wireless/mediatek/mt76/usb_mcu.c | 5 +- 6 files changed, 105 insertions(+), 54 deletions(-)
Signature · 1 line
2.20.1