Skip to content

iomap: fix multiple consistency issues, interface cleanup

Hugo Lefeuvre linux-arch lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4iomap: add missing function args identifier namesinclude/asm-generic/iomap.h+16 -160 replies
2/4iomap: add missing const to ioread*/iowrite addr arginclude/asm-generic/iomap.h lib/iomap.c+18 -180 replies
3/4io: change io*_rep definitions to take ulong countinclude/asm-generic/io.h+8 -80 replies
4/4lib/iomap: add missing const to mmio_ins* addr arglib/iomap.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] iomap: fix multiple consistency issues, interface cleanup

Hi,

This patch cleans up the iomap interface.

The first patch makes the include/asm-generic/iomap.h header compliant with the kernel style guidelines by adding missing function args identifier names.

The second and fourth patches address multiple compilation warnings due to missing const qualifiers in mmio_ins* and ioread*/iowrite definitions in include/asm-generic/iomap.h and lib/iomap.c.

The third patch modifies io*_rep definitions from asm-generic/io.h to take unsigned long count parameter instead of unsigned int which is inconsistent with other definitions in the kernel.

Hugo Lefeuvre (4):
iomap: add missing function args identifier names
iomap: add missing const to ioread*/iowrite addr arg
io: change io*_rep definitions to take ulong count lib/iomap: add missing const to mmio_ins* addr arg

 include/asm-generic/io.h    | 16 ++++++++--------
 include/asm-generic/iomap.h | 38 ++++++++++++++++++-------------------
 lib/iomap.c                 | 22 ++++++++++-----------
 3 files changed, 38 insertions(+), 38 deletions(-)
Signature · 1 line
2.20.1