Skip to content

perf evsel: add support for inlined function in callchains

Jonas Rabenstein linux-perf-users lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2perf evsel: split sample__fprintf_callchain in output and iterationtools/perf/util/evsel_fprintf.c+63 -480 replies
2/2perf evsel: add inline functions to sample callchain outputtools/perf/util/evsel_fprintf.c+46 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] perf evsel: add support for inlined function in callchains

Hi,
sample__fprintf_callchain currently did not use the already available code to get the symbols of an inlined function if such information is available in a dso. This patchset adds the required logic to add appropriate lines.

As I am quite new to the code base of perf I am not sure how to test that changeset in a correct way. At least the codes builds and the tools that make use of sample__fprintf_callchain (perf-script, perf-trace and perf-sched as far as I can see) did not fail to run - also I did not get into the details of perf-trace and perf-sched as I have never used them before.

Another thing I am not sure how to deal with are some warnings of checkpatch.pl due to the 80 character line limit. Due to the long function names in use the current implementation already exceeded that limit in the same spots by even more characters as I have taken the inner loop and put it into a separate function.

I hope to expand my work to perf-report but thought it might be usefull to get already early feedback on those patches.

Thank you,
Jonas

Jonas Rabenstein (2):
perf evsel: split sample__fprintf_callchain in output and iteration perf evsel: add inline functions to sample callchain output

 tools/perf/util/evsel_fprintf.c | 157 ++++++++++++++++++++++----------
 1 file changed, 109 insertions(+), 48 deletions(-)
Signature · 1 line
2.19.2