Skip to content

Improvements and fixups for vim2m driver

Mauro Carvalho Chehab linux-media 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10media: vim2m: add bayer capture formatsdrivers/media/platform/vim2m.c+95 -70 replies
2/10media: vim2m: improve debug messagesdrivers/media/platform/vim2m.c+32 -140 replies
3/10media: vim2m: ensure that width is multiple of twodrivers/media/platform/vim2m.c+1 -10 replies
4/10media: vim2m: add support for VIDIOC_ENUM_FRAMESIZESdrivers/media/platform/vim2m.c+29 -90 replies
5/10media: vim2m: use different framesizes for bayer formatsdrivers/media/platform/vim2m.c+34 -40 replies
6/10media: vim2m: better handle cap/out buffers with different sizesdrivers/media/platform/vim2m.c+81 -360 replies
7/10media: vim2m: add vertical linear scalerdrivers/media/platform/vim2m.c+32 -330 replies
8/10media: vim2m: don't accept YUYV anymore as output formatdrivers/media/platform/vim2m.c+2 -550 replies
9/10media: vim2m: add an horizontal scalerdrivers/media/platform/vim2m.c+55 -400 replies
10/10media: vim2m: speedup passthrough copydrivers/media/platform/vim2m.c+17 -200 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] Improvements and fixups for vim2m driver

The vim2m was laking care for a long time. It had several issues. Several were already fixed and are merged for Kernel 5.1, but there are still some pending things.

This patch series complement the work, making it do the right thing with regards to different resolutions at capture and output buffers.

Although it contains some improvements (like the addition of Bayer), I'm tempted to do a late merge for it, in order for the entire set of changes to go to Kernel 5.1, specially since:

a) It contains a fix at the buffer filling routine. At least this one should go to 5.1 anyway;

b) while the other patches could eventually go to 5.2, they also do significant changes at the buffer handling logic;

c) It disables YUYV as output format (due to the horizontal scaler). It would be good that such change would go together with the changes for 5.1 with actually implements YUYV support;

d) This is a test driver anyway and shouldn't affect systems in production.

e) As we're using it also to properly implement/fix Bayer support for M2M transform drivers at Gstreamer, it would be better to have everything altogether.

So, if nobody complains, I'll likely merge this series later today or along the weekend for Kernel 5.1.

Mauro Carvalho Chehab (10):
media: vim2m: add bayer capture formats
media: vim2m: improve debug messages
media: vim2m: ensure that width is multiple of two
media: vim2m: add support for VIDIOC_ENUM_FRAMESIZES
media: vim2m: use different framesizes for bayer formats
media: vim2m: better handle cap/out buffers with different sizes
media: vim2m: add vertical linear scaler
media: vim2m: don't accept YUYV anymore as output format
media: vim2m: add an horizontal scaler
media: vim2m: speedup passthrough copy

 drivers/media/platform/vim2m.c | 415 +++++++++++++++++++++++----------
 1 file changed, 287 insertions(+), 128 deletions(-)
Signature · 1 line
2.20.1