Skip to content

kms_flip: cleanups

Rodrigo Siqueira igt-dev intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7kms_flip: Removes unreachable code related to TEST_RPMtests/kms_flip.c+0 -150 replies
2/7kms_flip: Removes unreachable code related to TEST_TS_CONTtests/kms_flip.c+0 -160 replies
3/7kms_flip: Fix warning related to i915 gem dependencetests/kms_flip.c+6 -40 replies
4/7kms_flip: Remove unreachable condition in wait_for_eventstests/kms_flip.c+1 -31 reply
5/7kms_flip: Remove magic constant in run_test_on_crtc_set()tests/kms_flip.c+8 -40 replies
6/7kms_flip: Rework set_mode()tests/kms_flip.c+14 -120 replies
7/7kms_flip: Standardize return value for fb_is_boundtests/kms_flip.c+2 -32 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchMaarten Lankhorst
1/7
2/7
3/7
4/7
5/7
6/7
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [igt-dev] [PATCH i-g-t 0/7] kms_flip: cleanups

The last few weeks, I have been dive into the page flip and vblank with the goal to learn how the user space interact with DRM; because of this, I am studying the kms_flip code. As a result, I noticed a bunch of cleanups that could be useful for improving the overall quality of kms_flip. This patchset can be seen in two parts:

1. Eliminates unreachable tests
2. Basic cleanups with the goal to improve the code readability

In particular, the patch number three enables kms_flip to work without any issue in any non-intel drivers.

Rodrigo Siqueira (7):
kms_flip: Removes unreachable code related to TEST_RPM
kms_flip: Removes unreachable code related to TEST_TS_CONT
kms_flip: Fix warning related to i915 gem dependence
kms_flip: Remove unreachable condition in wait_for_events
kms_flip: remove magic constant in run_test_on_crtc_set()
kms_flip: Rework set_mode()
kms_flip: Standardize return value for fb_is_bound

 tests/kms_flip.c | 88 +++++++++++++++++-------------------------------
 1 file changed, 31 insertions(+), 57 deletions(-)
Signature · 1 line
2.21.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev