Skip to content

Fix backtrace warnings from bad notifier chain calls

Steve Twiss lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13regulator: da9055: Fix notifier mutex lock warningdrivers/regulator/da9055-regulator.c+2 -00 replies
2/13regulator: da9062: Fix notifier mutex lock warningdrivers/regulator/da9062-regulator.c+2 -00 replies
3/13regulator: da9063: Fix notifier mutex lock warningdrivers/regulator/da9063-regulator.c+4 -10 replies
4/13regulator: da9211: Fix notifier mutex lock warningdrivers/regulator/da9211-regulator.c+4 -00 replies
5/13regulator: lp8755: Fix notifier mutex lock warningdrivers/regulator/lp8755.c+12 -30 replies
6/13regulator: ltc3589: Fix notifier mutex lock warningdrivers/regulator/ltc3589.c+8 -20 replies
7/13regulator: ltc3676: Fix notifier mutex lock warningdrivers/regulator/ltc3676.c+8 -20 replies
8/13regulator: pv88060: Fix notifier mutex lock warningdrivers/regulator/pv88060-regulator.c+4 -00 replies
9/13regulator: pv88080: Fix notifier mutex lock warningdrivers/regulator/pv88080-regulator.c+4 -00 replies
10/13regulator: pv88090: Fix notifier mutex lock warningdrivers/regulator/pv88090-regulator.c+4 -00 replies
11/13regulator: wm831x: Fix notifier mutex lock warningdrivers/regulator/wm831x-dcdc.c+4 -01 reply
12/13regulator: wm831x isink: Fix notifier mutex lock warningdrivers/regulator/wm831x-isink.c+2 -01 reply
13/13regulator: wm831x ldo: Fix notifier mutex lock warningdrivers/regulator/wm831x-ldo.c+2 -01 reply

Reviews trailers per patch

3 of 13 patches have a Reviewed-by or Acked-by.

PatchCharles Keepax
1/13
2/13
3/13
4/13
5/13
6/13
7/13
8/13
9/13
10/13
11/13A-b
12/13A-b
13/13A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/13] Fix backtrace warnings from bad notifier chain calls

Hi Mark,

This patch-set fixes a WARN_ON_ONCE() backtrace call caused by not locking the mutex from the function call regulator_notifier_call_chain(). It does this for thirteen regulator drivers by adding a mutex lock surrounding the notifier calls.

This missing mutex lock has been around for a while, but the API I have used used here to fix it (i.e. regulator_lock()/regulator_unlock()) has only been in the kernel since v4.18. Therefore as this fix stands, the patches do not port back very far in kernel history.

Regards,
Steve

Steve Twiss (13):
regulator: da9055: Fix notifier mutex lock warning
regulator: da9062: Fix notifier mutex lock warning
regulator: da9063: Fix notifier mutex lock warning
regulator: da9211: Fix notifier mutex lock warning
regulator: lp8755: Fix notifier mutex lock warning
regulator: ltc3589: Fix notifier mutex lock warning
regulator: ltc3676: Fix notifier mutex lock warning
regulator: pv88060: Fix notifier mutex lock warning
regulator: pv88080: Fix notifier mutex lock warning
regulator: pv88090: Fix notifier mutex lock warning
regulator: wm831x: Fix notifier mutex lock warning
regulator: wm831x isink: Fix notifier mutex lock warning
regulator: wm831x ldo: Fix notifier mutex lock warning

 drivers/regulator/da9055-regulator.c  |  2 ++
 drivers/regulator/da9062-regulator.c  |  2 ++
 drivers/regulator/da9063-regulator.c  |  5 ++++-
 drivers/regulator/da9211-regulator.c  |  4 ++++
 drivers/regulator/lp8755.c            | 15 ++++++++++++---
 drivers/regulator/ltc3589.c           | 10 ++++++++--
 drivers/regulator/ltc3676.c           | 10 ++++++++--
 drivers/regulator/pv88060-regulator.c |  4 ++++
 drivers/regulator/pv88080-regulator.c |  4 ++++
 drivers/regulator/pv88090-regulator.c |  4 ++++
 drivers/regulator/wm831x-dcdc.c       |  4 ++++
 drivers/regulator/wm831x-isink.c      |  2 ++
 drivers/regulator/wm831x-ldo.c        |  2 ++
 13 files changed, 60 insertions(+), 8 deletions(-)
Signature · 1 line
1.9.3