Skip to content

Extent buffer locking cleanups

David Sterba linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9btrfs: add assertion helpers for spinning writersfs/btrfs/locking.c+24 -00 replies
2/9btrfs: use assertion helpers for spinning writersfs/btrfs/extent_io.c fs/btrfs/extent_io.h fs/btrfs/locking.c+11 -120 replies
3/9btrfs: add assertion helpers for spinning readersfs/btrfs/locking.c+13 -00 replies
4/9btrfs: use assertion helpers for spinning readersfs/btrfs/extent_io.c fs/btrfs/extent_io.h fs/btrfs/locking.c+7 -91 reply
5/9btrfs: add assertion helpers for extent buffer read lock countersfs/btrfs/locking.c+18 -70 replies
6/9btrfs: use assertion helpers for extent buffer read lock countersfs/btrfs/extent_io.c fs/btrfs/extent_io.h fs/btrfs/locking.c+7 -70 replies
7/9btrfs: add assertion helpers for extent buffer write lock countersfs/btrfs/locking.c+18 -50 replies
8/9btrfs: use assertion helpers for extent buffer write lock countersfs/btrfs/extent_io.c fs/btrfs/extent_io.h fs/btrfs/locking.c+5 -60 replies
9/9btrfs: switch extent_buffer::lock_nested to boolfs/btrfs/extent_io.c fs/btrfs/extent_io.h fs/btrfs/locking.c+5 -50 replies

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNikolay BorisovJohannes Thumshirn
SeriesR-b R-b
1/9
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] Extent buffer locking cleanups

The series moves several atomic counters under CONFIG_BTRFS_DEBUG. The selected counters are not essential for the extent buffer locking to work. There's some space saving (4x 4B at least) and the cachelines are less stressed on non-debugging builds.

The final size is 264 from 280, getting to 256 would be nice but hard or making the code unreadable. I have ideas to shave 7 more bytes but that's for another patchset.

David Sterba (9):
btrfs: add assertion helpers for spinning writers
btrfs: use assertion helpers for spinning writers
btrfs: add assertion helpers for spinning readers
btrfs: use assertion helpers for spinning readers
btrfs: add assertion helpers for extent buffer read lock counters
btrfs: use assertion helpers for extent buffer read lock counters
btrfs: add assertion helpers for extent buffer write lock counters
btrfs: use assertion helpers for extent buffer write lock counters
btrfs: switch extent_buffer::lock_nested to bool

 fs/btrfs/extent_io.c |  13 +++--
 fs/btrfs/extent_io.h |  11 ++--
 fs/btrfs/locking.c   | 133 ++++++++++++++++++++++++++++++-------------
 3 files changed, 107 insertions(+), 50 deletions(-)
Signature · 1 line
2.20.1