Skip to content

sctp: fix ignoring asoc_id for tcp-style sockets on some setsockopts

Xin Long linux-sctp netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_DEFAULT_SEND_PARAM sockoptnet/sctp/socket.c+3 -00 replies
2/13sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_DELAYED_SACK sockoptnet/sctp/socket.c+3 -00 replies
3/13sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_DEFAULT_SNDINFO sockoptnet/sctp/socket.c+3 -00 replies
4/13sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_CONTEXT sockoptnet/sctp/socket.c+3 -00 replies
5/13sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_MAX_BURST sockoptnet/sctp/socket.c+3 -00 replies
6/13sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_AUTH_KEY sockoptnet/sctp/socket.c+3 -00 replies
7/13sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_AUTH_ACTIVE_KEY sockoptnet/sctp/socket.c+3 -00 replies
8/13sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_AUTH_DELETE_KEY sockoptnet/sctp/socket.c+3 -00 replies
9/13sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_AUTH_DEACTIVATE_KEY sockoptnet/sctp/socket.c+3 -00 replies
10/13sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_DEFAULT_PRINFO sockoptnet/sctp/socket.c+3 -00 replies
11/13sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_ENABLE_STREAM_RESET sockoptnet/sctp/socket.c+3 -00 replies
12/13sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_EVENT sockoptnet/sctp/socket.c+3 -00 replies
13/13sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_STREAM_SCHEDULER sockoptnet/sctp/socket.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net 00/13] sctp: fix ignoring asoc_id for tcp-style sockets on some setsockopts

This is a patchset to fix ignoring asoc_id for tcp-style sockets on some setsockopts, introduced by SCTP_CURRENT_ASSOC of the patchset:

[net-next,00/24] sctp: support SCTP_FUTURE/CURRENT/ALL_ASSOC
(https://patchwork.ozlabs.org/cover/1031706/)

As Marcelo suggested, we fix it on each setsockopt that is using SCTP_CURRENT_ASSOC one by one by adding the check:

if (sctp_style(sk, TCP))
xxx.xxx_assoc_id = SCTP_FUTURE_ASSOC;

so that assoc_id will be completely ingored for tcp-style socket on setsockopts, and works as SCTP_FUTURE_ASSOC.

Marcelo Ricardo Leitner (1):
sctp: fix ignoring asoc_id for tcp-style sockets on
SCTP_DEFAULT_SEND_PARAM sockopt

Xin Long (12):
sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_DELAYED_SACK
sockopt
sctp: fix ignoring asoc_id for tcp-style sockets on
SCTP_DEFAULT_SNDINFO sockopt
sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_CONTEXT
sockopt
sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_MAX_BURST
sockopt
sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_AUTH_KEY
sockopt
sctp: fix ignoring asoc_id for tcp-style sockets on
SCTP_AUTH_ACTIVE_KEY sockopt
sctp: fix ignoring asoc_id for tcp-style sockets on
SCTP_AUTH_DELETE_KEY sockopt
sctp: fix ignoring asoc_id for tcp-style sockets on
SCTP_AUTH_DEACTIVATE_KEY sockopt
sctp: fix ignoring asoc_id for tcp-style sockets on
SCTP_DEFAULT_PRINFO sockopt
sctp: fix ignoring asoc_id for tcp-style sockets on
SCTP_ENABLE_STREAM_RESET sockopt
sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_EVENT sockopt
sctp: fix ignoring asoc_id for tcp-style sockets on
SCTP_STREAM_SCHEDULER sockopt

 net/sctp/socket.c | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)
Signature · 1 line
2.1.0