Skip to content

Redundant argument cleanups, part 1

David Sterba linux-btrfs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest30 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/30btrfs: get fs_info from eb in lock_extent_buffer_for_iofs/btrfs/extent_io.c+3 -40 replies
2/30btrfs: get fs_info from eb in repair_eb_io_failurefs/btrfs/disk-io.c fs/btrfs/extent_io.c fs/btrfs/extent_io.h+4 -50 replies
3/30btrfs: get fs_info from eb in write_one_ebfs/btrfs/extent_io.c+2 -30 replies
4/30btrfs: get fs_info from eb in leaf_data_endfs/btrfs/ctree.c fs/btrfs/ctree.h fs/btrfs/extent_io.c+15 -160 replies
5/30btrfs: get fs_info from eb in btrfs_exclude_logged_extentsfs/btrfs/ctree.h fs/btrfs/extent-tree.c fs/btrfs/tree-log.c+4 -50 replies
6/30btrfs: get fs_info from eb in check_tree_block_fsidfs/btrfs/disk-io.c+3 -30 replies
7/30btrfs: get fs_info from eb in tree_mod_log_eb_copyfs/btrfs/ctree.c+6 -70 replies
8/30btrfs: get fs_info from eb in clean_tree_blockfs/btrfs/ctree.c fs/btrfs/disk-io.c fs/btrfs/disk-io.h +4 more+19 -190 replies
9/30btrfs: get fs_info from eb in btrfs_leaf_free_spacefs/btrfs/ctree.c fs/btrfs/ctree.h fs/btrfs/delayed-inode.c +4 more+35 -390 replies
10/30btrfs: get fs_info from eb in read_node_slotfs/btrfs/ctree.c+12 -140 replies
11/30btrfs: get fs_info from eb in btree_read_extent_buffer_pagesfs/btrfs/disk-io.c+4 -70 replies
12/30btrfs: get fs_info from eb in btrfs_verify_level_keyfs/btrfs/ctree.c fs/btrfs/disk-io.c fs/btrfs/disk-io.h+5 -60 replies
13/30btrfs: tree-checker: get fs_info from eb in generic_errfs/btrfs/tree-checker.c+17 -170 replies
14/30btrfs: tree-checker: get fs_info from eb in file_extent_errfs/btrfs/tree-checker.c+11 -110 replies
15/30btrfs: tree-checker: get fs_info from eb in check_csum_itemfs/btrfs/tree-checker.c+3 -30 replies
16/30btrfs: tree-checker: get fs_info from eb in dir_item_errfs/btrfs/tree-checker.c+12 -120 replies
17/30btrfs: tree-checker: get fs_info from eb in check_dir_itemfs/btrfs/tree-checker.c+3 -30 replies
18/30btrfs: tree-checker: get fs_info from eb in block_group_errfs/btrfs/tree-checker.c+9 -90 replies
19/30btrfs: tree-checker: get fs_info from eb in check_block_group_itemfs/btrfs/tree-checker.c+2 -30 replies
20/30btrfs: tree-checker: get fs_info from eb in check_extent_data_itemfs/btrfs/tree-checker.c+3 -30 replies
21/30btrfs: tree-checker: get fs_info from eb in check_leaf_itemfs/btrfs/tree-checker.c+2 -30 replies
22/30btrfs: tree-checker: get fs_info from eb in check_leaffs/btrfs/tree-checker.c+6 -50 replies
23/30btrfs: get fs_info from eb in btrfs_check_leaf_fullfs/btrfs/disk-io.c fs/btrfs/tree-checker.c fs/btrfs/tree-checker.h+3 -50 replies
24/30btrfs: get fs_info from eb in btrfs_check_leaf_relaxedfs/btrfs/disk-io.c fs/btrfs/tree-checker.c fs/btrfs/tree-checker.h+3 -50 replies
25/30btrfs: get fs_info from eb in btrfs_check_nodefs/btrfs/disk-io.c fs/btrfs/tree-checker.c fs/btrfs/tree-checker.h+5 -40 replies
26/30btrfs: get fs_info from eb in should_balance_chunkfs/btrfs/volumes.c+3 -40 replies
27/30btrfs: get fs_info from eb in btrfs_check_chunk_validfs/btrfs/volumes.c+3 -30 replies
28/30btrfs: get fs_info from eb in read_one_chunkfs/btrfs/volumes.c+4 -40 replies
29/30btrfs: get fs_info from eb in read_one_chunkfs/btrfs/volumes.c+3 -30 replies
30/30btrfs: get fs_info from eb in btrfs_check_leaf_writefs/btrfs/disk-io.c fs/btrfs/tree-checker.c fs/btrfs/tree-checker.h+3 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/30] Redundant argument cleanups, part 1

This is first batch of utterly trivial changes that clean the cruft that accumulated over the years. When fs_info has been added to extent_buffer, few of the functions have been updated to reduce the redundant arugments.

This series removes fs_info/eb combination. There are more such pairs, patchsets will follow. Once all of them are cleaned, I strongly hope that new code will not reintroduce them.

As the changes touch a lot of files, I'll merge the series either partially or at some appropriate time not to create unnecessary conflicts with pending patches.

David Sterba (30):
btrfs: get fs_info from eb in lock_extent_buffer_for_io
btrfs: get fs_info from eb in repair_eb_io_failure
btrfs: get fs_info from eb in write_one_eb
btrfs: get fs_info from eb in leaf_data_end
btrfs: get fs_info from eb in btrfs_exclude_logged_extents
btrfs: get fs_info from eb in check_tree_block_fsid
btrfs: get fs_info from eb in tree_mod_log_eb_copy
btrfs: get fs_info from eb in clean_tree_block
btrfs: get fs_info from eb in btrfs_leaf_free_space
btrfs: get fs_info from eb in read_node_slot
btrfs: get fs_info from eb in btree_read_extent_buffer_pages
btrfs: get fs_info from eb in btrfs_verify_level_key
btrfs: tree-checker: get fs_info from eb in generic_err
btrfs: tree-checker: get fs_info from eb in file_extent_err
btrfs: tree-checker: get fs_info from eb in check_csum_item
btrfs: tree-checker: get fs_info from eb in dir_item_err
btrfs: tree-checker: get fs_info from eb in check_dir_item
btrfs: tree-checker: get fs_info from eb in block_group_err
btrfs: tree-checker: get fs_info from eb in check_block_group_item
btrfs: tree-checker: get fs_info from eb in check_extent_data_item
btrfs: tree-checker: get fs_info from eb in check_leaf_item
btrfs: tree-checker: get fs_info from eb in check_leaf
btrfs: get fs_info from eb in btrfs_check_leaf_full
btrfs: get fs_info from eb in btrfs_check_leaf_relaxed
btrfs: get fs_info from eb in btrfs_check_node
btrfs: get fs_info from eb in should_balance_chunk
btrfs: get fs_info from eb in btrfs_check_chunk_valid
btrfs: get fs_info from eb in read_one_chunk
btrfs: get fs_info from eb in read_one_chunk
btrfs: get fs_info from eb in btrfs_check_leaf_write

 fs/btrfs/ctree.c           | 139 +++++++++++++++++-----------------
 fs/btrfs/ctree.h           |  11 +--
 fs/btrfs/delayed-inode.c   |   3 +-
 fs/btrfs/disk-io.c         |  39 +++++-----
 fs/btrfs/disk-io.h         |   5 +-
 fs/btrfs/extent-tree.c     |  10 +--
 fs/btrfs/extent_io.c       |  18 ++---
 fs/btrfs/extent_io.h       |   3 +-
 fs/btrfs/file-item.c       |   4 +-
 fs/btrfs/file.c            |   2 +-
 fs/btrfs/free-space-tree.c |   2 +-
 fs/btrfs/print-tree.c      |   2 +-
 fs/btrfs/qgroup.c          |   2 +-
 fs/btrfs/tree-checker.c    | 149 ++++++++++++++++++-------------------
 fs/btrfs/tree-checker.h    |  11 +--
 fs/btrfs/tree-log.c        |   8 +-
 fs/btrfs/volumes.c         |  27 ++++---
 fs/btrfs/xattr.c           |   2 +-
 18 files changed, 207 insertions(+), 230 deletions(-)
Signature · 1 line
2.21.0