Skip to content

RFC fio-ccw fixes for kernel stacktraces

Farhan Ali kvm linux-s390 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest3 patches 16 repliesIn review
  2. v1 RFC1 of 3 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Use the return code from cio_cancel_halt_clear to prevent waiting unnecessarily (patch 2).

- No need to reset the device on the remove path (patch 3).

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3vfio-ccw: Do not call flush_workqueue while holding the spinlockdrivers/s390/cio/vfio_ccw_drv.c+1 -10 replies
2/3vfio-ccw: Prevent quiesce function going into an infinite loopdrivers/s390/cio/vfio_ccw_drv.c+12 -159 replies
3/3vfio-ccw: Release any channel program when releasing/removing vfio-ccw mdevdrivers/s390/cio/vfio_ccw_ops.c+10 -16 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchEric FarmanPierre Morel
1/3R-b R-b
2/3
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [RFC v2 0/3] fio-ccw fixes for kernel stacktraces

Hi,

I have recently seen some interesting kernel stacktraces while testing vfio-ccw mediated devices. These stack traces are seen when things don't go right, for example when a guest crashes or dies while still doing some I/O on the mediated device.

I have also come across an issue in the common vfio code as
well which I reported upstream (https://marc.info/?l=kvm&m=155369393523503&w=2)
and submitted a patch separately for it
(https://marc.info/?l=kvm&m=155414703613868&w=2).

I would appreciate any review or feedback on these patches.

Thanks
Farhan

ChangeLog
---------
v1 -> v2
- Use the return code from cio_cancel_halt_clear to prevent waiting unnecessarily (patch 2).

- No need to reset the device on the remove path (patch 3).

Farhan Ali (3):
vfio-ccw: Do not call flush_workqueue while holding the spinlock
vfio-ccw: Prevent quiesce function going into an infinite loop
vfio-ccw: Release any channel program when releasing/removing vfio-ccw
mdev

 drivers/s390/cio/vfio_ccw_drv.c | 27 ++++++++++++---------------
 drivers/s390/cio/vfio_ccw_ops.c | 11 ++++++++++-
 2 files changed, 22 insertions(+), 16 deletions(-)
Signature · 1 line
2.7.4