RFC Early task context tracking
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest7 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | x86/entry: Add support for early task context trackingarch/ arch/ arch/ +2 more | +51 | 0 replies | |
| 2/7 | trace: Move the trace recursion context enum to trace.h and reuse itkernel/ kernel/ | +26 | 0 replies | |
| 3/7 | trace: Optimize trace_get_context_bit()kernel/ | +6 | 0 replies | |
| 4/7 | trace/ring_buffer: Use trace_get_context_bit()kernel/ | +1 | 0 replies | |
| 5/7 | trace: Use early task context tracking if availablekernel/ | +12 | 0 replies | |
| 6/7 | events: Create an trace_get_context_bit()kernel/ | +28 | 0 replies | |
| 7/7 | events: Use early task context tracking if availablekernel/ | +13 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 0/7] Early task context tracking
Note: do not take it too seriously, it is just a proof of concept.
Some time ago, while using perf to check the automaton model, I noticed that perf was losing events. The same was reproducible with ftrace.
See: https://www.spinics.net/lists/linux-rt-users/msg19781.html
Steve pointed to a problem in the identification of the context execution used by the recursion control.
Currently, recursion control uses the preempt_counter to identify the current context. The NMI/HARD/SOFT IRQ counters are set in the preempt_counter in the irq_enter/exit functions.
In a trace, they are set like this:
-------------- %< --------------------
0) ==========> |
0) | do_IRQ() { /* First C function */
0) | irq_enter() {
0) | /* set the IRQ context. */
0) 1.081 us | }
0) | handle_irq() {
0) | /* IRQ handling code */
0) + 10.290 us | }
0) | irq_exit() {
0) | /* unset the IRQ context. */
0) 6.657 us | }
0) + 18.995 us | }
0) <========== |-------------- >% --------------------
As one can see, functions (and events) that take place before the set and after unset the preempt_counter are identified in the wrong context, causing the miss interpretation that a recursion is taking place. When this happens, events are dropped.
To resolve this problem, the set/unset of the IRQ/NMI context needs to be done before the execution of the first C execution, and after its return. By doing so, and using this method to identify the context in the trace recursion protection, no more events are lost.
A possible solution is to use a per-cpu variable set and unset in the entry point of NMI/IRQs, before calling the C handler. This possible solution is presented in the next patches as a proof of concept, for x86_64. However, other ideas might be better than mine... so...
Daniel Bristot de Oliveira (7):
x86/entry: Add support for early task context tracking
trace: Move the trace recursion context enum to trace.h and reuse it
trace: Optimize trace_get_context_bit() trace/ring_buffer: Use trace_get_context_bit()
trace: Use early task context tracking if available
events: Create an trace_get_context_bit()
events: Use early task context tracking if available
arch/x86/entry/entry_64.S | 9 ++++++ arch/x86/include/asm/irqflags.h | 30 ++++++++++++++++++++ arch/x86/kernel/cpu/common.c | 4 +++ include/linux/irqflags.h | 4 +++ kernel/events/internal.h | 50 +++++++++++++++++++++++++++------ kernel/softirq.c | 5 +++- kernel/trace/ring_buffer.c | 28 ++---------------- kernel/trace/trace.h | 46 ++++++++++++++++++++++-------- 8 files changed, 129 insertions(+), 47 deletions(-)
Signature · 1 line
2.20.1