Skip to content

block/pflash_cfi02: Implement missing AMD pflash functionality

Stephen Checkoway qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest10 patches 8 repliesIn review
  2. v310 patches 9 repliesSuperseded
  3. v210 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v110 patches13 repliesSuperseded

Changes in v4 from the cover letter

- Replace err.h/err() with glib functions; and
- Reformat qtest_initf lines.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10block/pflash_cfi02: Add test for supported commandstests/Makefile.include tests/pflash-cfi02-test.c+227 -01 reply
2/10block/pflash_cfi02: Refactor, NFC intendedhw/block/pflash_cfi02.c+95 -1261 reply
3/10block/pflash_cfi02: Fix command address comparisonhw/block/pflash_cfi02.c tests/pflash-cfi02-test.c+17 -30 replies
4/10block/pflash_cfi02: Implement intereleaved flash deviceshw/block/pflash_cfi02.c tests/pflash-cfi02-test.c+576 -1705 replies
5/10block/pflash_cfi02: Implement nonuniform sector sizeshw/block/pflash_cfi02.c tests/pflash-cfi02-test.c+265 -970 replies
6/10block/pflash_cfi02: Fix CFI in autoselect modehw/block/pflash_cfi02.c tests/pflash-cfi02-test.c+56 -40 replies
7/10block/pflash_cfi02: Fix reset command not ignored during erasehw/block/pflash_cfi02.c+2 -10 replies
8/10block/pflash_cfi02: Implement multi-sector erasehw/block/pflash_cfi02.c tests/pflash-cfi02-test.c+131 -220 replies
9/10block/pflash_cfi02: Implement erase suspend/resumehw/block/pflash_cfi02.c tests/pflash-cfi02-test.c+251 -140 replies
10/10block/pflash_cfi02: Use the chip erase time specified in the CFI tablehw/block/pflash_cfi02.c+2 -21 reply

Reviews trailers per patch

8 of 10 patches have a Reviewed-by or Acked-by.

PatchThomas HuthPhilippe Mathieu-Daudé
1/10A-b
2/10
3/10A-b
4/10A-b
5/10A-b
6/10A-b
7/10
8/10A-b
9/10A-b
10/10R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 00/10] block/pflash_cfi02: Implement missing AMD pflash functionality

The goal of this patch series implement the following AMD command-set parallel flash functionality:
- flash interleaving;
- nonuniform sector sizes;
- erase suspend/resume commands; and
- multi-sector erase.

During refactoring and implementation, I discovered several bugs that are fixed here as well:
- flash commands use only 11-bits of the address in most cases, but the current code uses all of them [1];
- entering CFI mode from autoselect mode and then exiting CFI mode should return the chip to autoselect mode, but the current code returns to read array mode; and
- reset command should be ignored during sector/chip erase, but the current code performs the reset.

The first patch in the series adds a test for the existing behavior. Tests for additional behavior/bug fixes are added in the relevant patch.

1. I found firmware in the wild that relies on the 11-bit address behavior, probably due to a bug in the firmware itself.

Changes from v1:
- Fix missing spaces around *, -, and ?;
- Fix missing Signed-off-by line on patch 7; and
- Replace use of errc with g_printerr and exit.

Changes from v2:
- Remove global_qtest from tests; and
- Test the CFI table changes.

Changes from v3:
- Replace err.h/err() with glib functions; and
- Reformat qtest_initf lines.

Stephen Checkoway (10):
block/pflash_cfi02: Add test for supported commands block/pflash_cfi02: Refactor, NFC intended block/pflash_cfi02: Fix command address comparison block/pflash_cfi02: Implement intereleaved flash devices block/pflash_cfi02: Implement nonuniform sector sizes block/pflash_cfi02: Fix CFI in autoselect mode block/pflash_cfi02: Fix reset command not ignored during erase block/pflash_cfi02: Implement multi-sector erase block/pflash_cfi02: Implement erase suspend/resume block/pflash_cfi02: Use the chip erase time specified in the CFI table

 hw/block/pflash_cfi02.c   | 843 +++++++++++++++++++++++++++-----------
 tests/Makefile.include    |   2 +
 tests/pflash-cfi02-test.c | 812 ++++++++++++++++++++++++++++++++++++
 3 files changed, 1420 insertions(+), 237 deletions(-)
 create mode 100644 tests/pflash-cfi02-test.c
Signature · 1 line
2.20.1 (Apple Git-117)