block/pflash_cfi02: Implement missing AMD pflash functionality
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest10 patches 8 repliesIn review
- v310 patches 9 repliesSuperseded
- v210 patches 0 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 10 patches | 13 replies | Superseded |
Changes in v4 from the cover letter
- Replace err.h/err() with glib functions; and
- Reformat qtest_initf lines.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | block/pflash_cfi02: Add test for supported commandstests/ tests/ | +227 | 1 reply | |
| 2/10 | block/pflash_cfi02: Refactor, NFC intendedhw/ | +95 | 1 reply | |
| 3/10 | block/pflash_cfi02: Fix command address comparisonhw/ tests/ | +17 | 0 replies | |
| 4/10 | block/pflash_cfi02: Implement intereleaved flash deviceshw/ tests/ | +576 | 5 replies | |
| 5/10 | block/pflash_cfi02: Implement nonuniform sector sizeshw/ tests/ | +265 | 0 replies | |
| 6/10 | block/pflash_cfi02: Fix CFI in autoselect modehw/ tests/ | +56 | 0 replies | |
| 7/10 | block/pflash_cfi02: Fix reset command not ignored during erasehw/ | +2 | 0 replies | |
| 8/10 | block/pflash_cfi02: Implement multi-sector erasehw/ tests/ | +131 | 0 replies | |
| 9/10 | block/pflash_cfi02: Implement erase suspend/resumehw/ tests/ | +251 | 0 replies | |
| 10/10 | block/pflash_cfi02: Use the chip erase time specified in the CFI tablehw/ | +2 | 1 reply |
Reviews trailers per patch
8 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Thomas Huth | Philippe Mathieu-Daudé |
|---|---|---|
| 1/10 | A-b | |
| 2/10 | ||
| 3/10 | A-b | |
| 4/10 | A-b | |
| 5/10 | A-b | |
| 6/10 | A-b | |
| 7/10 | ||
| 8/10 | A-b | |
| 9/10 | A-b | |
| 10/10 | R-b T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v4 00/10] block/pflash_cfi02: Implement missing AMD pflash functionality
The goal of this patch series implement the following AMD command-set parallel flash functionality:
- flash interleaving;
- nonuniform sector sizes;
- erase suspend/resume commands; and
- multi-sector erase.
During refactoring and implementation, I discovered several bugs that are fixed here as well:
- flash commands use only 11-bits of the address in most cases, but the current code uses all of them [1];
- entering CFI mode from autoselect mode and then exiting CFI mode should return the chip to autoselect mode, but the current code returns to read array mode; and
- reset command should be ignored during sector/chip erase, but the current code performs the reset.
The first patch in the series adds a test for the existing behavior. Tests for additional behavior/bug fixes are added in the relevant patch.
1. I found firmware in the wild that relies on the 11-bit address behavior, probably due to a bug in the firmware itself.
Changes from v1:
- Fix missing spaces around *, -, and ?;
- Fix missing Signed-off-by line on patch 7; and
- Replace use of errc with g_printerr and exit.
Changes from v2:
- Remove global_qtest from tests; and
- Test the CFI table changes.
Changes from v3:
- Replace err.h/err() with glib functions; and
- Reformat qtest_initf lines.
Stephen Checkoway (10):
block/pflash_cfi02: Add test for supported commands block/pflash_cfi02: Refactor, NFC intended block/pflash_cfi02: Fix command address comparison block/pflash_cfi02: Implement intereleaved flash devices block/pflash_cfi02: Implement nonuniform sector sizes block/pflash_cfi02: Fix CFI in autoselect mode block/pflash_cfi02: Fix reset command not ignored during erase block/pflash_cfi02: Implement multi-sector erase block/pflash_cfi02: Implement erase suspend/resume block/pflash_cfi02: Use the chip erase time specified in the CFI table
hw/block/pflash_cfi02.c | 843 +++++++++++++++++++++++++++----------- tests/Makefile.include | 2 + tests/pflash-cfi02-test.c | 812 ++++++++++++++++++++++++++++++++++++ 3 files changed, 1420 insertions(+), 237 deletions(-) create mode 100644 tests/pflash-cfi02-test.c
Signature · 1 line
2.20.1 (Apple Git-117)