net: atlantic: Aquantia driver updates 2019-04
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest15 patches 5 repliesIn review
- v315 patches 17 repliesSuperseded
- v216 patches 7 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 16 patches | 12 replies | Superseded |
Changes in v4 from the cover letter
- remove drvinfo_exit noop
- 64bit stats should be readed out sequentially (lsw, then msw) declare 64bit read ops for that
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | net: aquantia: add infrastructure to readout chip temperaturedrivers/ drivers/ drivers/ | +39 | 1 reply | |
| 2/15 | net: aquantia: implement hwmon api for chip temperaturedrivers/ drivers/ drivers/ +1 more | +144 | 1 reply | |
| 3/15 | net: aquantia: add link interrupt fieldsdrivers/ drivers/ | +4 | 0 replies | |
| 4/15 | net: aquantia: link interrupt handling functiondrivers/ | +14 | 0 replies | |
| 5/15 | net: aquantia: create global service workqueuedrivers/ drivers/ drivers/ +1 more | +56 | 0 replies | |
| 6/15 | net: aquantia: link status irq handlingdrivers/ drivers/ drivers/ +1 more | +50 | 0 replies | |
| 7/15 | net: aquantia: improve ifup link detectiondrivers/ | +1 | 0 replies | |
| 8/15 | net: aquantia: use macros for better visibilitydrivers/ drivers/ | +8 | 2 replies | |
| 9/15 | net: aquantia: user correct MSI irq typedrivers/ | +1 | 0 replies | |
| 10/15 | net: aquantia: introduce fwreq mutexdrivers/ drivers/ drivers/ +1 more | +42 | 0 replies | |
| 11/15 | net: aquantia: extract timer cb into work jobdrivers/ drivers/ | +20 | 0 replies | |
| 12/15 | net: aquantia: fetch up to date statistics on ethtool requestdrivers/ | +8 | 0 replies | |
| 13/15 | net: aquantia: get total counters from DMA blockdrivers/ | +5 | 0 replies | |
| 14/15 | net: aquantia: fixups on 64bit dma countersdrivers/ drivers/ drivers/ +3 more | +36 | 0 replies | |
| 15/15 | net: aquantia: remove outdated device idsdrivers/ drivers/ drivers/ | +0 | 0 replies |
Reviews trailers per patch
2 of 15 patches have a Reviewed-by or Acked-by.
| Patch | Nikita Danilov | Andrew Lunn |
|---|---|---|
| 1/15 | R-b | |
| 2/15 | R-b | |
| 3/15 | ||
| 4/15 | ||
| 5/15 | ||
| 6/15 | ||
| 7/15 | ||
| 8/15 | ||
| 9/15 | ||
| 10/15 | ||
| 11/15 | ||
| 12/15 | T-b | |
| 13/15 | ||
| 14/15 | T-b | |
| 15/15 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 net-next 00/15] net: atlantic: Aquantia driver updates 2019-04
This patchset contains various improvements:
- Work targeting link up speedups: link interrupt introduced, some other logic changes to imrove this.
- FW operations securing with mutex
- Counters and statistics logic improved by Dmitry
- read out of chip temperature via hwmon interface implemented by Yana and Nikita.
v4 changes:
- remove drvinfo_exit noop
- 64bit stats should be readed out sequentially (lsw, then msw) declare 64bit read ops for that
v3 changes:
- temp ops renamed to phy_temp ops
- mutex commits squashed for better structure
v2 changes:
- use threaded irq for link state handling
- rework hwmon via devm_hwmon_device_register_with_info Extra comments on review from Andrew:
- direct device name pointer is used in hwmon registration. This causes hwmon device to derive possible interface name changes
- Will consider sanity checks for firmware mutex lock separately. Right now there is no single point exsists where such check could be easily added.
- There is no way now to fetch and configure min/max/crit temperatures via FW. Will investigate this separately.
Dmitry Bogdanov (3):
net: aquantia: fetch up to date statistics on ethtool request
net: aquantia: get total counters from DMA block
net: aquantia: fixups on 64bit dma counters
Igor Russkikh (7):
net: aquantia: add link interrupt fields
net: aquantia: link interrupt handling function
net: aquantia: link status irq handling
net: aquantia: improve ifup link detection
net: aquantia: use macros for better visibility
net: aquantia: user correct MSI irq type
net: aquantia: extract timer cb into work job
Nikita Danilov (3):
net: aquantia: create global service workqueue
net: aquantia: introduce fwreq mutex
net: aquantia: remove outdated device ids
Yana Esina (2):
net: aquantia: add infrastructure to readout chip temperature
net: aquantia: implement hwmon api for chip temperature
.../net/ethernet/aquantia/atlantic/Makefile | 1 + .../ethernet/aquantia/atlantic/aq_common.h | 3 - .../ethernet/aquantia/atlantic/aq_drvinfo.c | 125 ++++++++++++++++++ .../ethernet/aquantia/atlantic/aq_drvinfo.h | 15 +++ .../ethernet/aquantia/atlantic/aq_ethtool.c | 22 ++- .../net/ethernet/aquantia/atlantic/aq_hw.h | 4 + .../ethernet/aquantia/atlantic/aq_hw_utils.c | 12 ++ .../ethernet/aquantia/atlantic/aq_hw_utils.h | 1 + .../net/ethernet/aquantia/atlantic/aq_main.c | 41 ++++++ .../net/ethernet/aquantia/atlantic/aq_main.h | 2 + .../net/ethernet/aquantia/atlantic/aq_nic.c | 120 +++++++++++++---- .../net/ethernet/aquantia/atlantic/aq_nic.h | 6 +- .../ethernet/aquantia/atlantic/aq_pci_func.c | 48 ++++--- .../ethernet/aquantia/atlantic/aq_pci_func.h | 7 +- .../aquantia/atlantic/hw_atl/hw_atl_a0.c | 8 +- .../aquantia/atlantic/hw_atl/hw_atl_b0.c | 13 +- .../aquantia/atlantic/hw_atl/hw_atl_b0.h | 3 - .../aquantia/atlantic/hw_atl/hw_atl_llh.c | 41 ++---- .../aquantia/atlantic/hw_atl/hw_atl_llh.h | 31 ++--- .../atlantic/hw_atl/hw_atl_llh_internal.h | 3 - .../aquantia/atlantic/hw_atl/hw_atl_utils.c | 13 +- .../atlantic/hw_atl/hw_atl_utils_fw2x.c | 36 +++++ 22 files changed, 427 insertions(+), 128 deletions(-) create mode 100644 drivers/net/ethernet/aquantia/atlantic/aq_drvinfo.c create mode 100644 drivers/net/ethernet/aquantia/atlantic/aq_drvinfo.h
Signature · 1 line
2.17.1