Skip to content

net: atlantic: Aquantia driver updates 2019-04

Igor Russkikh netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest15 patches 5 repliesIn review
  2. v315 patches 17 repliesSuperseded
  3. v216 patches 7 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v116 patches12 repliesSuperseded

Changes in v4 from the cover letter

- remove drvinfo_exit noop
- 64bit stats should be readed out sequentially (lsw, then msw) declare 64bit read ops for that

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15net: aquantia: add infrastructure to readout chip temperaturedrivers/net/ethernet/aquantia/atlantic/aq_hw.h drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c+39 -01 reply
2/15net: aquantia: implement hwmon api for chip temperaturedrivers/net/ethernet/aquantia/atlantic/Makefile drivers/net/ethernet/aquantia/atlantic/aq_drvinfo.c drivers/net/ethernet/aquantia/atlantic/aq_drvinfo.h +1 more+144 -01 reply
3/15net: aquantia: add link interrupt fieldsdrivers/net/ethernet/aquantia/atlantic/aq_hw.h drivers/net/ethernet/aquantia/atlantic/aq_nic.h+4 -10 replies
4/15net: aquantia: link interrupt handling functiondrivers/net/ethernet/aquantia/atlantic/aq_nic.c+14 -00 replies
5/15net: aquantia: create global service workqueuedrivers/net/ethernet/aquantia/atlantic/aq_main.c drivers/net/ethernet/aquantia/atlantic/aq_main.h drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c +1 more+56 -10 replies
6/15net: aquantia: link status irq handlingdrivers/net/ethernet/aquantia/atlantic/aq_nic.c drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c drivers/net/ethernet/aquantia/atlantic/aq_pci_func.h +1 more+50 -190 replies
7/15net: aquantia: improve ifup link detectiondrivers/net/ethernet/aquantia/atlantic/aq_nic.c+1 -20 replies
8/15net: aquantia: use macros for better visibilitydrivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c+8 -82 replies
9/15net: aquantia: user correct MSI irq typedrivers/net/ethernet/aquantia/atlantic/aq_pci_func.c+1 -10 replies
10/15net: aquantia: introduce fwreq mutexdrivers/net/ethernet/aquantia/atlantic/aq_ethtool.c drivers/net/ethernet/aquantia/atlantic/aq_nic.c drivers/net/ethernet/aquantia/atlantic/aq_nic.h +1 more+42 -100 replies
11/15net: aquantia: extract timer cb into work jobdrivers/net/ethernet/aquantia/atlantic/aq_nic.c drivers/net/ethernet/aquantia/atlantic/aq_nic.h+20 -60 replies
12/15net: aquantia: fetch up to date statistics on ethtool requestdrivers/net/ethernet/aquantia/atlantic/aq_nic.c+8 -10 replies
13/15net: aquantia: get total counters from DMA blockdrivers/net/ethernet/aquantia/atlantic/aq_nic.c+5 -40 replies
14/15net: aquantia: fixups on 64bit dma countersdrivers/net/ethernet/aquantia/atlantic/aq_hw_utils.c drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.h drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_llh.c +3 more+36 -640 replies
15/15net: aquantia: remove outdated device idsdrivers/net/ethernet/aquantia/atlantic/aq_common.h drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.h+0 -120 replies

Reviews trailers per patch

2 of 15 patches have a Reviewed-by or Acked-by.

PatchNikita DanilovAndrew Lunn
1/15R-b
2/15R-b
3/15
4/15
5/15
6/15
7/15
8/15
9/15
10/15
11/15
12/15T-b
13/15
14/15T-b
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 net-next 00/15] net: atlantic: Aquantia driver updates 2019-04

This patchset contains various improvements:

- Work targeting link up speedups: link interrupt introduced, some other logic changes to imrove this.
- FW operations securing with mutex
- Counters and statistics logic improved by Dmitry
- read out of chip temperature via hwmon interface implemented by Yana and Nikita.

v4 changes:
- remove drvinfo_exit noop
- 64bit stats should be readed out sequentially (lsw, then msw) declare 64bit read ops for that

v3 changes:
- temp ops renamed to phy_temp ops
- mutex commits squashed for better structure

v2 changes:
- use threaded irq for link state handling
- rework hwmon via devm_hwmon_device_register_with_info Extra comments on review from Andrew:
- direct device name pointer is used in hwmon registration. This causes hwmon device to derive possible interface name changes
- Will consider sanity checks for firmware mutex lock separately. Right now there is no single point exsists where such check could be easily added.
- There is no way now to fetch and configure min/max/crit temperatures via FW. Will investigate this separately.

Dmitry Bogdanov (3):
net: aquantia: fetch up to date statistics on ethtool request
net: aquantia: get total counters from DMA block
net: aquantia: fixups on 64bit dma counters

Igor Russkikh (7):
net: aquantia: add link interrupt fields
net: aquantia: link interrupt handling function
net: aquantia: link status irq handling
net: aquantia: improve ifup link detection
net: aquantia: use macros for better visibility
net: aquantia: user correct MSI irq type
net: aquantia: extract timer cb into work job

Nikita Danilov (3):
net: aquantia: create global service workqueue
net: aquantia: introduce fwreq mutex
net: aquantia: remove outdated device ids

Yana Esina (2):
net: aquantia: add infrastructure to readout chip temperature
net: aquantia: implement hwmon api for chip temperature

 .../net/ethernet/aquantia/atlantic/Makefile   |   1 +
 .../ethernet/aquantia/atlantic/aq_common.h    |   3 -
 .../ethernet/aquantia/atlantic/aq_drvinfo.c   | 125 ++++++++++++++++++
 .../ethernet/aquantia/atlantic/aq_drvinfo.h   |  15 +++
 .../ethernet/aquantia/atlantic/aq_ethtool.c   |  22 ++-
 .../net/ethernet/aquantia/atlantic/aq_hw.h    |   4 +
 .../ethernet/aquantia/atlantic/aq_hw_utils.c  |  12 ++
 .../ethernet/aquantia/atlantic/aq_hw_utils.h  |   1 +
 .../net/ethernet/aquantia/atlantic/aq_main.c  |  41 ++++++
 .../net/ethernet/aquantia/atlantic/aq_main.h  |   2 +
 .../net/ethernet/aquantia/atlantic/aq_nic.c   | 120 +++++++++++++----
 .../net/ethernet/aquantia/atlantic/aq_nic.h   |   6 +-
 .../ethernet/aquantia/atlantic/aq_pci_func.c  |  48 ++++---
 .../ethernet/aquantia/atlantic/aq_pci_func.h  |   7 +-
 .../aquantia/atlantic/hw_atl/hw_atl_a0.c      |   8 +-
 .../aquantia/atlantic/hw_atl/hw_atl_b0.c      |  13 +-
 .../aquantia/atlantic/hw_atl/hw_atl_b0.h      |   3 -
 .../aquantia/atlantic/hw_atl/hw_atl_llh.c     |  41 ++----
 .../aquantia/atlantic/hw_atl/hw_atl_llh.h     |  31 ++---
 .../atlantic/hw_atl/hw_atl_llh_internal.h     |   3 -
 .../aquantia/atlantic/hw_atl/hw_atl_utils.c   |  13 +-
 .../atlantic/hw_atl/hw_atl_utils_fw2x.c       |  36 +++++
 22 files changed, 427 insertions(+), 128 deletions(-)
 create mode 100644 drivers/net/ethernet/aquantia/atlantic/aq_drvinfo.c
 create mode 100644 drivers/net/ethernet/aquantia/atlantic/aq_drvinfo.h
Signature · 1 line
2.17.1