Skip to content

mptcp: refactor xmit path

Paolo Abeni mptcp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesIn review

Changes in v1 from the cover letter

- addressed Mat's feedback, dropping patch 3/4 and switching to per msk page frag use, and checking mptcp seq number for coalescing

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mptcp: use sk_page_frag() in sendmsgnet/mptcp/protocol.c+20 -210 replies
2/3mptcp: sendmsg() do spool all the provided datanet/mptcp/protocol.c+53 -380 replies
3/3mptcp: allow collapsing consecutive sendpages on the same substreamnet/mptcp/protocol.c+60 -172 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [MPTCP] [PATCH 0/3] mptcp: refactor xmit path

his series refactor the mptcp xmit path trying to make sendmsg behavior more consistent, memory efficent and improve its performances.

The code is also available here:

https://github.com/pabeni/mptcp/tree/mptcp-proposal-devel

To support MP_JOIN and multiple subflows, the idea is adding, with later patches, an RB-tree structure containing references to the pending page fragments, their length and the associated mptcp write_seq number (is subflow rel_write_seq needed, too?). RB-tree node can be allocated using the same page frag used in this series for skb data. Each RB-tree node will own a reference to the page frag.

RFC -> v1:
- addressed Mat's feedback, dropping patch 3/4 and switching to per msk page frag use, and checking mptcp seq number for coalescing

Paolo Abeni (3):
mptcp: use sk_page_frag() in sendmsg
mptcp: sendmsg() do spool all the provided data
mptcp: allow collapsing consecutive sendpages on the same substream

 net/mptcp/protocol.c | 181 ++++++++++++++++++++++++++++---------------
 1 file changed, 119 insertions(+), 62 deletions(-)
Signature · 1 line
2.20.1