Skip to content

A few hist trigger fixes

Tom Zanussi linux-rt-users lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 of 3 patches 0 repliesNew

1 of 3 patches is in this archive. The cover letter announces 3.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
3/3tracing: Add a check_val() check before updating cond_snapshot() track_valkernel/trace/trace_events_hist.c+6 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] A few hist trigger fixes

From: Tom Zanussi <[email protected]>

Hi Steve,

Here's a fix for a problem I found with the hist trigger snapshot action related to the refactoring in the later versions of the patchset ('[PATCH 3/3] tracing: Add a check_val() check before updating cond_snapshot() track_val').

I also added v2 of 2 other patches that I previously submitted [1] but realized hadn't gotten picked up. ('[PATCH v2 1/3] tracing: Prevent hist_field_var_ref() from accessing NULL tracing_map_elts' and '[PATCH v2 2/3] tracing: Check keys for variable references in expressions too').

One of them I had to rebase ('[PATCH v2 2/3] tracing: Check keys for variable references in expressions too') because of the error_log changes since then, but the original ones still apply to versions before that).

So in summary, all of these patches apply to current ftrace/core, while only '[PATCH 3/3] tracing: Add a check_val() check before updating cond_snapshot() track_val' and the previous 2 original patches in [1] apply to mainline.

Thanks,

Tom

[1] https://lore.kernel.org/lkml/[email protected]/

The following changes since commit c8faaa4c594f55ddf903d61180029a3ea1da5286:

rcu: validate arguments for rcu tracepoints (2019-04-03 08:26:38 -0400)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/key-ref-fix-v2

Tom Zanussi (3):
tracing: Prevent hist_field_var_ref() from accessing NULL
tracing_map_elts
tracing: Check keys for variable references in expressions too
tracing: Add a check_val() check before updating cond_snapshot()
track_val

 kernel/trace/trace_events_hist.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
Signature · 1 line
2.14.1