gdb/scripts: Improve lx-clk-summary
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | scripts/gdb: Cleanup error handling in list helpersscripts/ | +2 | 1 reply | |
| 2/2 | scripts/gdb: Print cached rate in lx-clk-summaryscripts/ scripts/ | +18 | 0 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Stephen Boyd |
|---|---|
| 1/2 | R-b |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] gdb/scripts: Improve lx-clk-summary
The earlier series adding clk support to gdb/scripts was quickly accepted but some concerns were raised by Stephen Boyd so this series attempts to address them.
Link to previous series: https://lkml.org/lkml/2019/4/22/55
This is not a v2 and squashing is not expected.
Fields other than clk rate not covered because they're much more rarely used and cache logic can get more complicated and brittle.
LX_GDBPARSED is used in constants.py.in because python does not understand C integer literal suffixes like the "1UL" from the definition of BIT() used by CLK_GET_RATE_NOCACHE. Alternative workarounds would be hacking away UL suffixes with sed or redefining BIT&co but relying on gdb evaluation is easier and much more flexible.
Leonard Crestez (2):
scripts/gdb: Cleanup error handling in list helpers scripts/gdb: Print cached rate in lx-clk-summary
scripts/gdb/linux/clk.py | 21 ++++++++++++++------- scripts/gdb/linux/constants.py.in | 4 ++++ scripts/gdb/linux/lists.py | 10 ++-------- 3 files changed, 20 insertions(+), 15 deletions(-)
Signature · 1 line
2.17.1