Skip to content

9p: Fix file ID collisions

Christian Schoenebeck via Qemu-devel qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest3 patches 18 repliesIn review
  2. v64 patches 32 repliesSuperseded
  3. v55 patches 5 repliesApplied
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v45 patches16 repliesSuperseded
v35 patches4 repliesSuperseded

Changes in v7 from the cover letter

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/39p: Added virtfs option 'multidevs=remap|forbid|warn'fsdev/file-op-9p.h fsdev/qemu-fsdev-opts.c fsdev/qemu-fsdev.c +4 more+237 -250 replies
2/39p: stat_to_qid: implement slow pathhw/9pfs/9p.c hw/9pfs/9p.h+76 -70 replies
3/39p: Use variable length suffixes for inode remappinghw/9pfs/9p.c hw/9pfs/9p.h+279 -330 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v7 yet.

Read the v7 thread

Cover letter [Qemu-devel] [PATCH v7 0/3] 9p: Fix file ID collisions

This is v7 of a proposed patch set for fixing file ID collisions with 9pfs.

v6->v7:

* Rebased to https://github.com/gkurz/qemu/commits/9p-next

    (SHA1 7fc4c49e91).

* Be pedantic and abort with error on wrong value for new command line argument 'multidevs'.

* Adjusted patches to qemu code style guidelines.

* Fixed potential crash in qp_table_destroy() on error path.

* Use dedicated hash table init functions (qpd_table_init(),

    qpf_table_init(), qpp_table_init()):
    https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg00144.html

* Use warn_report_once() instead of error_report_once() for issues interpreted merely as being warnings, not errors.

* Simplified hash table destruction (due to simplified error path

    introduced by SHA1 7fc4c49e91).

* Dropped capturing root_ino for now:

    https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg00146.html

* Don't update proxy docs, since new command line argument 'multidevs' is limited to the local backend for now.

* Mention in docs that readdir() is currently not blocked by 'multidevs=forbid'.

* Rename qid_path_prefixmap() -> qid_path_suffixmap() in patch 3 (due to the semantic change of that function by that patch).

Christian Schoenebeck (3):
9p: Added virtfs option 'multidevs=remap|forbid|warn' 9p: stat_to_qid: implement slow path
9p: Use variable length suffixes for inode remapping

 fsdev/file-op-9p.h      |   5 +
 fsdev/qemu-fsdev-opts.c |   7 +-
 fsdev/qemu-fsdev.c      |  17 ++
 hw/9pfs/9p.c            | 456 ++++++++++++++++++++++++++++++++++++++--
 hw/9pfs/9p.h            |  59 ++++++
 qemu-options.hx         |  26 ++-
 vl.c                    |   7 +-
 7 files changed, 552 insertions(+), 25 deletions(-)
Signature · 1 line
2.20.1