Skip to content

mptcp: refactor xmit path

Paolo Abeni mptcp 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 2 repliesIn review
  2. v13 patches 1 replySuperseded

Changes in v3 from the cover letter

- rebased on top of "mptcp: refactor shutdown/close and conn_list handling"
- cope with egres pkt with NULL ext

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mptcp: use sk_page_frag() in sendmsgnet/mptcp/protocol.c+20 -210 replies
2/3mptcp: sendmsg() do spool all the provided datanet/mptcp/protocol.c+63 -470 replies
3/3mptcp: allow collapsing consecutive sendpages on the same substreamnet/mptcp/protocol.c+60 -190 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [MPTCP] [PATCH v3 0/3] mptcp: refactor xmit path

this series refactor the mptcp xmit path trying to make sendmsg behavior more consistent, memory efficent and improve its performances.

Self-test results are not affected: tests fail in similar way before and after this series.

To support MP_JOIN and multiple subflows, the idea is adding, with later patches, an RB-tree structure containing references to the pending page fragments, their length and the associated mptcp write_seq number (is subflow rel_write_seq needed, too?). RB-tree node can be allocated using the same page frag used in this series for skb data. Each RB-tree node will own a reference to the page frag.

v2 -> v3:
- rebased on top of "mptcp: refactor shutdown/close and conn_list handling"
- cope with egres pkt with NULL ext

v1 -> v2:
- rebased on top of current git
- fix handling of some corner cases

RFC -> v1:
- addressed Mat's feedback, dropping patch 3/4 and switching to per msk page frag use, and checking mptcp seq number for coalescing

Paolo Abeni (3):
mptcp: use sk_page_frag() in sendmsg
mptcp: sendmsg() do spool all the provided data
mptcp: allow collapsing consecutive sendpages on the same substream

 net/mptcp/protocol.c | 190 ++++++++++++++++++++++++++++---------------
 1 file changed, 123 insertions(+), 67 deletions(-)
Signature · 1 line
2.20.1