Updates to staging driver: kpc_i2c
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | staging: kpc2000: kpc_i2c: reindent i2c_driver.cdrivers/ | +507 | 0 replies | |
| 2/5 | staging: kpc2000: kpc_i2c: reformat copyright for better readabilitydrivers/ | +18 | 0 replies | |
| 3/5 | staging: kpc2000: kpc_i2c: prevent memory leak in probe() error casedrivers/ | +1 | 0 replies | |
| 4/5 | staging: kpc2000: kpc_i2c: use %s with __func__ identifier in log messagesdrivers/ | +15 | 2 replies | |
| 5/5 | staging: kpc2000: kpc_i2c: fixup block comment style in i2c_driver.cdrivers/ | +21 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5] Updates to staging driver: kpc_i2c
Attached are an assortment of updates to the kpc_i2c driver in the staging subtree.
As a quick summary:
Patches 1, 4, and 5 address style concerns raised by the checkpatch script. Patch 1 (a reindentation fix) likely added additional 'line length' warnings, but given the fact that they were only hidden due to a nonstandard indentation style, I elected to defer that work to a future patchset. If the reviewers should disagree with that choice, I'd be happy to fix up those issues in a v2 upload.
Patch 2 is a reformatting / reorganization of the copyright header at the top of the file. I attempted to look at some other drivers in the i2c subsystem for inspiration, but I'd be happy to drop this isn't as simple an update as it seems.
Patch 3 addresses a potential bug in the cleanup of memory allocated in the probe method.
Geordan Neukum (5):
staging: kpc2000: kpc_i2c: reindent i2c_driver.c
staging: kpc2000: kpc_i2c: reformat copyright for better readability
staging: kpc2000: kpc_i2c: prevent memory leak in probe() error case
staging: kpc2000: kpc_i2c: use %s with __func__ identifier in log
messages
staging: kpc2000: kpc_i2c: fixup block comment style in i2c_driver.c
drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 1043 +++++++++--------- 1 file changed, 527 insertions(+), 516 deletions(-)
--
2.21.0