Skip to content

net: stmmac: Improvements and Selftests

Jose Abreu lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest18 patches 1 replyIn review
  2. v118 patches 3 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18net: stmmac: Add MAC loopback callback to HWIFdrivers/net/ethernet/stmicro/stmmac/hwif.h+4 -00 replies
2/18net: stmmac: dwmac100: Add MAC loopback supportdrivers/net/ethernet/stmicro/stmmac/dwmac100_core.c+13 -00 replies
3/18net: stmmac: dwmac1000: Add MAC loopback supportdrivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c+13 -00 replies
4/18net: stmmac: dwmac4/5: Add MAC loopback supportdrivers/net/ethernet/stmicro/stmmac/dwmac4.h drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c+16 -00 replies
5/18net: stmmac: dwxgmac2: Add MAC loopback supportdrivers/net/ethernet/stmicro/stmmac/dwxgmac2.h drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c+14 -00 replies
6/18net: ethernet: stmmac: dwmac-sun8i: Enable control of loopbackdrivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c+13 -00 replies
7/18net: stmmac: Switch MMC functions to HWIF callbacksdrivers/net/ethernet/stmicro/stmmac/common.h drivers/net/ethernet/stmicro/stmmac/hwif.c drivers/net/ethernet/stmicro/stmmac/hwif.h +4 more+40 -100 replies
8/18net: stmmac: dwmac1000: Also pass control frames while in promisc modedrivers/net/ethernet/stmicro/stmmac/dwmac1000.h drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c+2 -10 replies
9/18net: stmmac: dwmac4/5: Also pass control frames while in promisc modedrivers/net/ethernet/stmicro/stmmac/dwmac4.h drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c+2 -10 replies
10/18net: stmmac: dwxgmac2: Also pass control frames while in promisc modedrivers/net/ethernet/stmicro/stmmac/dwxgmac2.h drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c+2 -10 replies
11/18net: stmmac: Introduce selftests supportdrivers/net/ethernet/stmicro/stmmac/Kconfig drivers/net/ethernet/stmicro/stmmac/Makefile drivers/net/ethernet/stmicro/stmmac/stmmac.h +2 more+889 -00 replies
12/18net: stmmac: dwmac1000: Fix Hash Filterdrivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c+1 -00 replies
13/18net: stmmac: dwmac1000: Clear unused address entriesdrivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c+6 -00 replies
14/18net: stmmac: dwmac4/5: Fix Hash Filterdrivers/net/ethernet/stmicro/stmmac/dwmac4.h drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c+3 -00 replies
15/18net: stmmac: dwmac4/5: Do not disable whole RX in dma_stop_rx()drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c+0 -40 replies
16/18net: stmmac: dwxgmac2: Do not disable whole RX in dma_stop_rx()drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c+0 -40 replies
17/18net: stmmac: dwmac4/5: Clear unused address entriesdrivers/net/ethernet/stmicro/stmmac/dwmac4_core.c+8 -20 replies
18/18net: stmmac: Prevent missing interrupts when running NAPIdrivers/net/ethernet/stmicro/stmmac/stmmac_main.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net-next v2 00/18] net: stmmac: Improvements and Selftests

[ Thanks to the introducion of selftests this series ended up being a misc of improvements and the selftests additions per-se. ]

This introduces selftests support in stmmac driver. We add 9 basic sanity checks and MAC loopback support for all cores within the driver. This way more tests can easily be added in the future and can be run in virtually any MAC/GMAC/QoS/XGMAC platform.

Having this we can find regressions and missing features in the driver while at the same time we can check if the IP is correctly working.

We have been using this for some time now and I do have more tests to submit in the feature. My experience is that although writing the tests adds more development time, the gain results are obvious.

I let this feature optional within the driver under a Kconfig option.

Cc Joao Pinto <[email protected]>
Cc David S. Miller <[email protected]>
Cc Giuseppe Cavallaro <[email protected]>
Cc Alexandre Torgue <[email protected]>
Cc Corentin Labbe <[email protected]>
Cc Andrew Lunn <[email protected]>

Corentin Labbe (1):
net: ethernet: stmmac: dwmac-sun8i: Enable control of loopback

Jose Abreu (17):
net: stmmac: Add MAC loopback callback to HWIF
net: stmmac: dwmac100: Add MAC loopback support
net: stmmac: dwmac1000: Add MAC loopback support
net: stmmac: dwmac4/5: Add MAC loopback support
net: stmmac: dwxgmac2: Add MAC loopback support
net: stmmac: Switch MMC functions to HWIF callbacks
net: stmmac: dwmac1000: Also pass control frames while in promisc mode
net: stmmac: dwmac4/5: Also pass control frames while in promisc mode
net: stmmac: dwxgmac2: Also pass control frames while in promisc mode
net: stmmac: Introduce selftests support
net: stmmac: dwmac1000: Fix Hash Filter
net: stmmac: dwmac1000: Clear unused address entries
net: stmmac: dwmac4/5: Fix Hash Filter
net: stmmac: dwmac4/5: Do not disable whole RX in dma_stop_rx()
net: stmmac: dwxgmac2: Do not disable whole RX in dma_stop_rx()
net: stmmac: dwmac4/5: Clear unused address entries
net: stmmac: Prevent missing interrupts when running NAPI

 drivers/net/ethernet/stmicro/stmmac/Kconfig        |   9 +
 drivers/net/ethernet/stmicro/stmmac/Makefile       |   2 +
 drivers/net/ethernet/stmicro/stmmac/common.h       |   1 +
 drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c  |  13 +
 drivers/net/ethernet/stmicro/stmmac/dwmac1000.h    |   1 +
 .../net/ethernet/stmicro/stmmac/dwmac1000_core.c   |  22 +-
 .../net/ethernet/stmicro/stmmac/dwmac100_core.c    |  13 +
 drivers/net/ethernet/stmicro/stmmac/dwmac4.h       |   3 +
 drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c  |  29 +-
 drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c   |   4 -
 drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h     |   2 +
 .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c    |  15 +-
 drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c |   4 -
 drivers/net/ethernet/stmicro/stmmac/hwif.c         |   9 +
 drivers/net/ethernet/stmicro/stmmac/hwif.h         |  21 +
 drivers/net/ethernet/stmicro/stmmac/mmc.h          |   4 -
 drivers/net/ethernet/stmicro/stmmac/mmc_core.c     |  13 +-
 drivers/net/ethernet/stmicro/stmmac/stmmac.h       |  22 +
 .../net/ethernet/stmicro/stmmac/stmmac_ethtool.c   |   8 +-
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c  |   7 +-
 .../net/ethernet/stmicro/stmmac/stmmac_selftests.c | 850 +++++++++++++++++++++
 21 files changed, 1029 insertions(+), 23 deletions(-)
 create mode 100644 drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
Signature · 1 line
2.7.4