Make shared memory config non-public
Status from this message: Applied, thanks
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest9 patches 8 repliesApplied
- v48 patches 0 repliesSuperseded
- v314 patches 14 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 14 patches | 2 replies | Superseded | |
| v1 | 25 patches | 18 replies | Superseded |
Changes in v5 from the cover letter
- Accidentally squashed last patch into another patch
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | eal: add API to lock/unlock memory hotplugdrivers/ drivers/ drivers/ +11 more | +125 | 0 replies | |
| 2/9 | eal: add EAL tailq list lock/unlock APIlib/ lib/ lib/ +17 more | +165 | 0 replies | |
| 3/9 | eal: add new API to lock/unlock mempool listlib/ lib/ lib/ +2 more | +65 | 0 replies | |
| 4/9 | eal: hide shared memory configapp/ app/ app/ +35 more | +148 | 3 replies | |
| 5/9 | eal: remove packed attribute from mcfg structurelib/ | +1 | 0 replies | |
| 6/9 | eal: uninline wait for mcfg complete functionlib/ lib/ lib/ +1 more | +16 | 0 replies | |
| 7/9 | eal: unify and move mcfg complete functionlib/ lib/ lib/ +1 more | +20 | 0 replies | |
| 8/9 | eal: unify internal config initializationlib/ lib/ lib/ +1 more | +30 | 0 replies | |
| 9/9 | eal: prevent different primary/secondary process versionslib/ lib/ lib/ +1 more | +29 | 0 replies |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Stephen Hemminger | David Marchand |
|---|---|---|
| 1/9 | A-b | A-b |
| 2/9 | A-b | A-b |
| 3/9 | A-b | A-b |
| 4/9 | A-b | A-b |
| 5/9 | A-b | A-b |
| 6/9 | A-b | A-b |
| 7/9 | A-b | A-b |
| 8/9 | A-b | A-b |
| 9/9 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [dpdk-dev] [PATCH v5 0/9] Make shared memory config non-public
This patchset removes the shared memory config from public API, and replaces all usages of said config with new API calls.
A lot of the patchset is a search-and-replace job and should be pretty easy to review. The rest are pretty trivial EAL changes.
v5:
- Accidentally squashed last patch into another patch
v4:
- Rebase on top of latest master
- Squashed more commits
- Added some cleanups
- Comment cleanup in mem config
- Moved memseg list struct to rte_memory
- Fixed init in FreeBSD when storing data in config
v3:
- Rebase on top of latest master
v2:
- Collapsed all changes into fewer patches
- Addressed review comments
- Created a new file to store the code
- Changed namespace to "rte_mcfg_"
- Added some unification around config init
- Removed "packed" attribute from mem config
- Removed unnecessary inlining
- Added a check to explicitly forbid running multiprocess applications that differ in their DPDK versions
Anatoly Burakov (9):
eal: add API to lock/unlock memory hotplug
eal: add EAL tailq list lock/unlock API
eal: add new API to lock/unlock mempool list
eal: hide shared memory config
eal: remove packed attribute from mcfg structure
eal: uninline wait for mcfg complete function
eal: unify and move mcfg complete function
eal: unify internal config initialization
eal: prevent different primary/secondary process versions
app/test/test_fbarray.c | 1 + app/test/test_memzone.c | 1 + app/test/test_tailq.c | 1 + doc/guides/rel_notes/deprecation.rst | 3 - doc/guides/rel_notes/release_19_08.rst | 8 +- drivers/bus/fslmc/fslmc_vfio.c | 8 +- drivers/bus/pci/linux/pci_vfio.c | 1 + drivers/net/mlx4/mlx4_mr.c | 11 +- drivers/net/mlx5/mlx5_mr.c | 11 +- .../net/virtio/virtio_user/virtio_user_dev.c | 7 +- lib/librte_acl/rte_acl.c | 20 +-- lib/librte_distributor/rte_distributor.c | 5 +- lib/librte_distributor/rte_distributor_v20.c | 5 +- lib/librte_eal/common/eal_common_mcfg.c | 149 ++++++++++++++++++ lib/librte_eal/common/eal_common_memory.c | 44 +++--- lib/librte_eal/common/eal_common_memzone.c | 1 + lib/librte_eal/common/eal_common_tailqs.c | 5 +- lib/librte_eal/common/eal_memcfg.h | 94 +++++++++++ lib/librte_eal/common/include/rte_eal.h | 10 -- .../common/include/rte_eal_memconfig.h | 135 +++++++--------- lib/librte_eal/common/include/rte_fbarray.h | 1 - lib/librte_eal/common/include/rte_memory.h | 24 ++- lib/librte_eal/common/malloc_heap.c | 16 +- lib/librte_eal/common/malloc_mp.c | 1 + lib/librte_eal/common/meson.build | 1 + lib/librte_eal/common/rte_malloc.c | 33 ++-- lib/librte_eal/freebsd/eal/Makefile | 3 +- lib/librte_eal/freebsd/eal/eal.c | 21 ++- lib/librte_eal/freebsd/eal/eal_memory.c | 1 + lib/librte_eal/linux/eal/Makefile | 3 +- lib/librte_eal/linux/eal/eal.c | 41 ++--- lib/librte_eal/linux/eal/eal_memalloc.c | 1 + lib/librte_eal/linux/eal/eal_memory.c | 1 + lib/librte_eal/linux/eal/eal_vfio.c | 17 +- lib/librte_eal/meson.build | 2 +- lib/librte_eal/rte_eal_version.map | 12 ++ lib/librte_efd/rte_efd.c | 15 +- lib/librte_eventdev/rte_event_ring.c | 16 +- lib/librte_hash/rte_cuckoo_hash.c | 17 +- lib/librte_hash/rte_fbk_hash.c | 15 +- lib/librte_kni/rte_kni.c | 16 +- lib/librte_lpm/rte_lpm.c | 25 +-- lib/librte_lpm/rte_lpm6.c | 15 +- lib/librte_member/rte_member.c | 17 +- lib/librte_mempool/rte_mempool.c | 27 ++-- lib/librte_rcu/rte_rcu_qsbr.h | 1 + lib/librte_reorder/rte_reorder.c | 15 +- lib/librte_ring/rte_ring.c | 19 +-- lib/librte_stack/rte_stack.c | 18 +-- 49 files changed, 575 insertions(+), 339 deletions(-) create mode 100644 lib/librte_eal/common/eal_common_mcfg.c create mode 100644 lib/librte_eal/common/eal_memcfg.h
Signature · 1 line
2.17.1