Skip to content

net/sched: fix actions reading the network header in case of QinQ packets

Davide Caratti netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 17 repliesIn review
  2. v23 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- don't inline tc_skb_pull_vlans(), thanks to Stephen Hemminger
- remove unwanted whitespace in patch #3

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net/sched: act_csum: pull all VLAN headers before checksumminginclude/net/pkt_cls.h net/sched/act_csum.c net/sched/cls_api.c+26 -125 replies
2/3net/sched: act_pedit: fix 'ex munge' on network header in case of QinQ packetnet/sched/act_pedit.c+22 -40 replies
3/3net/sched: act_skbedit: fix 'inheritdsfield' in case of QinQ packetnet/sched/act_skbedit.c+20 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH net v3 0/3] net/sched: fix actions reading the network header in case of QinQ packets

'act_csum' was recently fixed to mangle the IPv4/IPv6 header if a packet having one or more VLAN headers was processed: patch #1 ensures that all VLAN headers are in the linear area of the skb.
Other actions might read or mangle the IPv4/IPv6 header: patch #2 and #3 fix 'act_pedit' and 'act_skbedit' respectively.

Changes since v2:
- don't inline tc_skb_pull_vlans(), thanks to Stephen Hemminger
- remove unwanted whitespace in patch #3

Changes since v1:
- add patch #1, thanks to Eric Dumazet
- add patch #3

Davide Caratti (3):
net/sched: act_csum: pull all VLAN headers before checksumming net/sched: act_pedit: fix 'ex munge' on network header in case of QinQ
packet
net/sched: act_skbedit: fix 'inheritdsfield' in case of QinQ packet

 include/net/pkt_cls.h   |  2 ++
 net/sched/act_csum.c    | 14 ++------------
 net/sched/act_pedit.c   | 26 ++++++++++++++++++++++----
 net/sched/act_skbedit.c | 24 ++++++++++++++++++++----
 net/sched/cls_api.c     | 22 ++++++++++++++++++++++
 5 files changed, 68 insertions(+), 20 deletions(-)
Signature · 1 line
2.20.1