Skip to content

staging: rtl8712: cleanup struct _adapter

Deepak Mishra lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 1 replyIn review
  2. v46 patches 3 repliesSuperseded
  3. v34 patches 3 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6staging: rtl8712: Fixed CamelCase for EepromAddressSizedrivers/staging/rtl8712/drv_types.h drivers/staging/rtl8712/rtl871x_eeprom.c drivers/staging/rtl8712/usb_intf.c+5 -50 replies
2/6staging: rtl8712: Removed redundant code from function oid_rt_pro_write_register_hdldrivers/staging/rtl8712/drv_types.h drivers/staging/rtl8712/rtl871x_mp_ioctl.c+0 -60 replies
3/6staging: rtl8712: Fixed CamelCase cmdThread rename to cmd_threaddrivers/staging/rtl8712/drv_types.h drivers/staging/rtl8712/os_intfs.c+4 -40 replies
4/6staging: rtl8712: removed unused variables from struct _adapterdrivers/staging/rtl8712/drv_types.h+0 -40 replies
5/6staging: rtl8712: Renamed CamelCase wkFilterRxFF0 to wk_filter_rx_ff0drivers/staging/rtl8712/drv_types.h drivers/staging/rtl8712/rtl871x_xmit.c drivers/staging/rtl8712/xmit_linux.c+3 -31 reply
6/6staging: rtl8712: Renamed CamelCase lockRxFF0Filter to lock_rx_ff0_filterdrivers/staging/rtl8712/drv_types.h drivers/staging/rtl8712/usb_intf.c drivers/staging/rtl8712/xmit_linux.c+4 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/6] staging: rtl8712: cleanup struct _adapter

In process of cleaning up rtl8712 struct _adapter in drv_types.h I have tried to remove some unused variables and redundant lines of code associated with those variables. I have also fixed some CamelCase reported by checkpatch.pl

Following review comments from previous versions are addressed
1. Separated CamelCase fix for lockRxFF0Filter and wkFilterRxFF0 to separate patches
2. Separated CamelCase EepromAddressSizefrom removal of unused variable ImrContent two different patches.
3. Remove redundant code along with removing variable ImrContent from the structure
4. Instead of fixing CamelCase issue, remove the variables not in use.
5. Fixing of CamelCase of variable blnEnableRxFF0Filter is removed from this patch set as spinning on a random variable for synchronization needs to be fixed separately

Deepak Mishra (6):
staging: rtl8712: Fixed CamelCase for EepromAddressSize
staging: rtl8712: Removed redundant code from function
oid_rt_pro_write_register_hdl
staging: rtl8712: Fixed CamelCase cmdThread rename to cmd_thread
staging: rtl8712: removed unused variables from struct _adapter
staging: rtl8712: Renamed CamelCase wkFilterRxFF0 to wk_filter_rx_ff0
staging: rtl8712: Renamed CamelCase lockRxFF0Filter to
lock_rx_ff0_filter

 drivers/staging/rtl8712/drv_types.h        | 13 ++++---------
 drivers/staging/rtl8712/os_intfs.c         |  6 +++---
 drivers/staging/rtl8712/rtl871x_eeprom.c   |  6 +++---
 drivers/staging/rtl8712/rtl871x_mp_ioctl.c |  5 -----
 drivers/staging/rtl8712/rtl871x_xmit.c     |  2 +-
 drivers/staging/rtl8712/usb_intf.c         |  4 ++--
 drivers/staging/rtl8712/xmit_linux.c       |  6 +++---
 7 files changed, 16 insertions(+), 26 deletions(-)
Signature · 1 line
2.19.1