Skip to content

drm/vkms: Introduces writeback support

Rodrigo Siqueira dri-devel lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 14 repliesIn review
  2. v25 patches 6 repliesSuperseded
  3. v12 patches 13 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/vkms: Avoid assigning 0 for possible_crtcdrivers/gpu/drm/vkms/vkms_drv.c drivers/gpu/drm/vkms/vkms_drv.h drivers/gpu/drm/vkms/vkms_output.c +1 more+8 -81 reply
2/5drm/vkms: Rename vkms_crc.c into vkms_composer.cdrivers/gpu/drm/vkms/Makefile drivers/gpu/drm/vkms/vkms_composer.c drivers/gpu/drm/vkms/vkms_crtc.c +3 more+101 -971 reply
3/5drm/vkms: Decouple crc operations from composerdrivers/gpu/drm/vkms/vkms_composer.c+29 -202 replies
4/5drm/vkms: Compute CRC without change input datadrivers/gpu/drm/vkms/vkms_composer.c+19 -127 replies
5/5drm/vkms: Add support for writebackdrivers/gpu/drm/vkms/Makefile drivers/gpu/drm/vkms/vkms_composer.c drivers/gpu/drm/vkms/vkms_drv.c +3 more+185 -33 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchDaniel Vetter
1/5R-b
2/5A-b
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH V3 0/5] drm/vkms: Introduces writeback support

This is the V3 version of a series that introduces the writeback support to vkms. As a result of the previous review, this patchset can be seen in three parts: make vkms able to support multiple connector, pre-work for vkms, and the vkms implementation. Follows the details:

* First part: The first patch of this series is a fix that enables vkms to accept new connectors, such as writeback connector.

* Second part: The second part of this patchset starts on patch 02 and finish on patch 04; basically it is a pre-work that aims to make vkms composer operations a little bit more generic. These patches update the CRC files and function to make it work as a composer; it also centralizes the vkms framebuffer operations. Additionally, these changes enable the composer to use the writeback framebuffer instead of creating a copy.

* Third part: The final patch enables the support for writeback in vkms.

With this patchset, vkms can successfully pass all the kms_writeback tests from IGT.

Note: Most of the changes in the V3 was suggested by Daniel Vetter as can be seen at the link
https://patchwork.freedesktop.org/patch/311844/?series=61738&rev=2

Note: This patchset depends on Daniel's rework of CRC, see it at
https://patchwork.freedesktop.org/series/61737/

Rodrigo Siqueira (5):
drm/vkms: Avoid assigning 0 for possible_crtc drm/vkms: Rename vkms_crc.c into vkms_composer.c drm/vkms: Decouple crc operations from composer drm/vkms: Compute CRC without change input data drm/vkms: Add support for writeback

 drivers/gpu/drm/vkms/Makefile                 |   9 +-
 .../drm/vkms/{vkms_crc.c => vkms_composer.c}  | 174 ++++++++++--------
 drivers/gpu/drm/vkms/vkms_crtc.c              |  30 +--
 drivers/gpu/drm/vkms/vkms_drv.c               |  10 +-
 drivers/gpu/drm/vkms/vkms_drv.h               |  40 ++--
 drivers/gpu/drm/vkms/vkms_output.c            |  16 +-
 drivers/gpu/drm/vkms/vkms_plane.c             |  40 ++--
 drivers/gpu/drm/vkms/vkms_writeback.c         | 141 ++++++++++++++
 8 files changed, 331 insertions(+), 129 deletions(-)
 rename drivers/gpu/drm/vkms/{vkms_crc.c => vkms_composer.c} (51%)
 create mode 100644 drivers/gpu/drm/vkms/vkms_writeback.c
Signature · 10 lines
2.21.0


-- 
Rodrigo Siqueira
https://siqueira.tech
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel