Add support for testing writeback connectors
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v9 Latest4 patches 3 repliesIn review
- v84 patches 3 repliesSuperseded
- v74 patches 14 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v6 | 6 patches | 28 replies | Superseded |
Patches in v9 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | lib/igt_kms: Add writeback supportlib/ lib/ | +58 | 0 replies | |
| 2/4 | kms_writeback: Add initial writeback teststests/ tests/ tests/ | +318 | 0 replies | |
| 3/4 | lib: Add function to hash a framebufferlib/ lib/ | +65 | 0 replies | |
| 4/4 | kms_writeback: Add writeback-check-outputtests/ | +134 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Liviu Dudau | Simon Ser |
|---|---|---|
| 1/4 | R-b | R-b |
| 2/4 | R-b | |
| 3/4 | R-b | R-b |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [igt-dev] [PATCH i-g-t v9 0/4] Add support for testing writeback connectors
Hi,
A couple of months ago I updated and re-submitted a patchset made by Brian Starkey and Liviu Dudau for adding a writeback connectors test to IGT. It is important to highlight that DRM already have writeback connectors support, which is a way to expose in DRM the hardware functionality from display engines that allows writing back into memory the result of DE's composition of supported planes.
After I resubmitted the patchset, Simon Ser provides a long and detailed review for all of the patches (thanks Simon). Additionally, Maxime Ripard tested the previous series in an ARM32 architecture and provided his feedback for making this patchset portable (thanks Maxime). I finally had time to go through all the details and prepare this new version. Follows some notes:
1. Patchset author
Brian Starkey is the original author of this patchset, and I'm just trying to upstream his changes. Note that during this patch submission, the mail server from google going to overwrite Brian's mail by mine; this happens on the mail server side for avoiding malicious users to send emails as someone else. Note that I could spend time figuring out how to fix it, but I think this is not worth it since I can fix it during the merge process (if it got accepted).
2. Drop the clone commits from the series
After Simon's review, we decided to drop the last two patches of the original series since it was related to cloning output and VKMS does not support it yet. However, after we finish this series, I can try to take a look at this feature or maybe propose it as a GSoC/Outreachy project.
Most of the changes happened in the second patch.
3. Cross-platform improvements
4. Add test description and remove some unnecessary code
Thanks
Brian Starkey (4):
lib/igt_kms: Add writeback support
kms_writeback: Add initial writeback tests
lib: Add function to hash a framebuffer
kms_writeback: Add writeback-check-output
lib/igt_fb.c | 63 ++++++ lib/igt_fb.h | 2 + lib/igt_kms.c | 52 +++++ lib/igt_kms.h | 6 + tests/Makefile.sources | 1 + tests/kms_writeback.c | 450 +++++++++++++++++++++++++++++++++++++++++ tests/meson.build | 1 + 7 files changed, 575 insertions(+) create mode 100644 tests/kms_writeback.c
Signature · 6 lines
2.28.0 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev