Skip to content

Fix misuse of blk_rq_stats in blk-iolatency

Pavel Begunkov (Silence) linux-block lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 5 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2blk-iolatency: Fix zero mean in previous statsblock/blk-iolatency.c block/blk-stat.c block/blk-stat.h+36 -80 replies
2/2blk-stats: Introduce explicit stat staging buffersblock/blk-iolatency.c block/blk-stat.c block/blk-stat.h +1 more+61 -240 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJosef Bacik
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [RESEND][PATCH v2 0/2] Fix misuse of blk_rq_stats in blk-iolatency

From: Pavel Begunkov <[email protected]>

There are implicit assumptions about struct blk_rq_stats, which make it's very easy to misuse. The first patch fixes a bug caused by that. The second employs type-system to prevent recurrences.

v2: rebase + reformulate commit messages (no code changes)

Acked-by Josef Bacik <[email protected]>

Pavel Begunkov (2):
blk-iolatency: Fix zero mean in previous stats
blk-stats: Introduce explicit stat staging buffers

 block/blk-iolatency.c     | 60 ++++++++++++++++++++++++++++++---------
 block/blk-stat.c          | 48 +++++++++++++++++++++++--------
 block/blk-stat.h          |  9 ++++--
 include/linux/blk_types.h |  6 ++++
 4 files changed, 94 insertions(+), 29 deletions(-)
Signature · 1 line
2.22.0

Read the cover letter in its thread