Skip to content

powerpc/ftrace: Patch out -mprofile-kernel instructions

Naveen N. Rao linuxppc-dev lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 13 repliesIn review
  2. v17 patches 15 repliesSuperseded

Changes in v2 from the cover letter

(https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=114556):
- Patches 1,2,3 and 6: No changes
- Patch 4: Add smp_call_function() to flush icache on all cpus after patching in the 'mflr r0' instruction.
- Patch 5: Changes as per Steven Rostedt's suggestions.
- Patch 7: Changes as per Masami and Joe Perches.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ftrace: Expose flags used for ftrace_replace_code()include/linux/ftrace.h kernel/trace/ftrace.c+5 -52 replies
2/7x86/ftrace: Fix use of flags in ftrace_replace_code()arch/x86/kernel/ftrace.c+2 -13 replies
3/7ftrace: Expose __ftrace_replace_code()include/linux/ftrace.h kernel/trace/ftrace.c+5 -41 reply
4/7powerpc/ftrace: Additionally nop out the preceding mflr with -mprofile-kernelarch/powerpc/kernel/trace/ftrace.c+236 -226 replies
5/7ftrace: Update ftrace_location() for powerpc -mprofile-kernelarch/powerpc/include/asm/ftrace.h include/linux/ftrace.h kernel/trace/ftrace.c+18 -10 replies
6/7kprobes/ftrace: Use ftrace_location() when [dis]arming probeskernel/kprobes.c+5 -50 replies
7/7powerpc/kprobes: Allow probing on any ftrace addressarch/powerpc/kernel/kprobes-ftrace.c+31 -11 reply

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchSteven Rostedt (VMware)Nicholas PigginMasami Hiramatsu
1/7R-b
2/7
3/7R-b
4/7R-b
5/7
6/7A-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/7] powerpc/ftrace: Patch out -mprofile-kernel instructions

Changes since v1
(https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=114556):
- Patches 1,2,3 and 6: No changes
- Patch 4: Add smp_call_function() to flush icache on all cpus after patching in the 'mflr r0' instruction.
- Patch 5: Changes as per Steven Rostedt's suggestions.
- Patch 7: Changes as per Masami and Joe Perches.

--
On powerpc64, -mprofile-kernel results in two instructions being
emitted: 'mflr r0' and 'bl _mcount'. So far, we were only nop'ing out the branch to _mcount(). This series implements an approach to also nop out the preceding mflr.

- Naveen

Naveen N. Rao (7):
ftrace: Expose flags used for ftrace_replace_code() x86/ftrace: Fix use of flags in ftrace_replace_code()
ftrace: Expose __ftrace_replace_code() powerpc/ftrace: Additionally nop out the preceding mflr with
-mprofile-kernel
ftrace: Update ftrace_location() for powerpc -mprofile-kernel kprobes/ftrace: Use ftrace_location() when [dis]arming probes powerpc/kprobes: Allow probing on any ftrace address

 arch/powerpc/include/asm/ftrace.h    |   8 +
 arch/powerpc/kernel/kprobes-ftrace.c |  32 +++-
 arch/powerpc/kernel/trace/ftrace.c   | 258 ++++++++++++++++++++++++---
 arch/x86/kernel/ftrace.c             |   3 +-
 include/linux/ftrace.h               |  15 ++
 kernel/kprobes.c                     |  10 +-
 kernel/trace/ftrace.c                |  15 +-
 7 files changed, 302 insertions(+), 39 deletions(-)
Signature · 1 line
2.22.0