Skip to content

coresight: Do not default to CPU0 for missing CPU phandle

Sai Prakash Ranjan linux-arm-kernel linux-arm-msm lkml 6 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest posting 2/22 patches 0 repliesNew
  2. v5 posting 1/22 patches 9 repliesSuperseded
  3. v4 posting 2/21 patch 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v4 posting 1/21 patch0 repliesSuperseded
v31 patch4 repliesSuperseded
v22 patches4 repliesSuperseded

Changes in v5 from the cover letter

* Separate out the dt-bindings patch.

Patches in v5 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: coresight: Change CPU phandle to required propertyDocumentation/devicetree/bindings/arm/coresight-cpu-debug.txt Documentation/devicetree/bindings/arm/coresight.txt+7 -50 replies
2/2coresight: Do not default to CPU0 for missing CPU phandledrivers/hwtracing/coresight/coresight-cpu-debug.c drivers/hwtracing/coresight/coresight-etm3x.c drivers/hwtracing/coresight/coresight-etm4x.c +1 more+19 -100 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSuzuki K PouloseMathieu Poirier
1/2R-b T-b R-b
2/2R-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [RESEND PATCHv5 0/2] coresight: Do not default to CPU0 for missing CPU phandle

In case of missing CPU phandle, the affinity is set default to CPU0 which is not a correct assumption. Fix this in coresight platform to set affinity to invalid and abort the probe in drivers. Also update the dt-bindings accordingly.

Resending with tags added.

v5:
* Separate out the dt-bindings patch.

v4:
* Fix return for !CONFIG_ACPI and !CONFIG_OF.

v3:
* Addressed review comments from Suzuki and updated acpi_coresight_get_cpu.
* Removed patch 2 which had invalid check for online cpus.

v2:
* Addressed review comments from Suzuki and Mathieu.
* Allows the probe of etm and cpu-debug to abort earlier in case of unavailability of respective cpus.

Sai Prakash Ranjan (2):
dt-bindings: coresight: Change CPU phandle to required property
coresight: Do not default to CPU0 for missing CPU phandle

 .../bindings/arm/coresight-cpu-debug.txt      |  4 ++--
 .../devicetree/bindings/arm/coresight.txt     |  8 +++++---
 .../hwtracing/coresight/coresight-cpu-debug.c |  3 +++
 drivers/hwtracing/coresight/coresight-etm3x.c |  3 +++
 drivers/hwtracing/coresight/coresight-etm4x.c |  3 +++
 .../hwtracing/coresight/coresight-platform.c  | 20 +++++++++----------
 6 files changed, 26 insertions(+), 15 deletions(-)
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation