Skip to content

ipset: Two fixes for destination MAC address matches in ip,mac types

Stefano Brivio netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ipset: Actually allow destination MAC address for hash:ip,mac sets tookernel/net/netfilter/ipset/ip_set_hash_ipmac.c+0 -40 replies
2/2ipset: Copy the right MAC address in bitmap:ip,mac and hash:ip,mac setskernel/net/netfilter/ipset/ip_set_bitmap_ipmac.c kernel/net/netfilter/ipset/ip_set_hash_ipmac.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] ipset: Two fixes for destination MAC address matches in ip,mac types

Commit 8cc4ccf58379 ("ipset: Allow matching on destination MAC address for mac and ipmac sets"), ipset.git commit 1543514c46a7, properly allows destination matching for hash:mac set types, but missed to remove the previous restriction for type hash:ip,mac and introduced an obvious mistake in both bitmap:ip,mac and hash:ip,mac.

Drop the left-over check and correct the mistake, to fix the issue reported by Chen Yi.

Stefano Brivio (2):
ipset: Actually allow destination MAC address for hash:ip,mac sets too
ipset: Copy the right MAC address in bitmap:ip,mac and hash:ip,mac
sets

 kernel/net/netfilter/ipset/ip_set_bitmap_ipmac.c | 2 +-
 kernel/net/netfilter/ipset/ip_set_hash_ipmac.c   | 6 +-----
 2 files changed, 2 insertions(+), 6 deletions(-)
Signature · 1 line
2.20.1