Skip to content

Fix timer resource leak

Anatoly Burakov dpdk-dev 3 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest1 patch 1 replyApplied
  2. v21 patch 0 repliesSuperseded
  3. v12 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- Accidentally squashed with previous patch, reverted

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/1timer: fix resource leak in finalizelib/librte_eal/common/eal_common_mcfg.c lib/librte_eal/common/eal_memcfg.h lib/librte_eal/common/include/rte_eal_memconfig.h +3 more+71 -151 reply

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchErik Gabriel CarrilloDavid Marchand
1/1A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [dpdk-dev] [PATCH v3 0/1] Fix timer resource leak

Previous attempts [1] at fixing the resource leak have been deemed unsuccessful because of limitations around what can be done without breaking the ABI. Now that we've broken the EAL ABI, we can fix this issue properly.

This patchset is adding a new lock API, as well as fixes the actual issue.

The patchset depends on mem config patchset [2].

v3:
- Accidentally squashed with previous patch, reverted

v2:
- Addressed review comments and squashed patches

[1] http://patches.dpdk.org/patch/53334/
[2] http://patches.dpdk.org/project/dpdk/list/?series=5369

Anatoly Burakov (1):
timer: fix resource leak in finalize

 lib/librte_eal/common/eal_common_mcfg.c       | 14 +++++++
 lib/librte_eal/common/eal_memcfg.h            |  2 +
 .../common/include/rte_eal_memconfig.h        | 22 ++++++++++
 lib/librte_eal/rte_eal_version.map            |  2 +
 lib/librte_timer/rte_timer.c                  | 41 +++++++++++++------
 lib/librte_timer/rte_timer.h                  |  5 ++-
 6 files changed, 71 insertions(+), 15 deletions(-)
Signature · 1 line
2.17.1