Skip to content

tracing: Improve error messages for histogram sorting

Tom Zanussi lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 4 repliesIn review
  2. v14 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4tracing: Simplify assignment parsing for hist triggerskernel/trace/trace_events_hist.c+27 -430 replies
2/4tracing: Add hist trigger error messages for sort specificationkernel/trace/trace_events_hist.c+17 -40 replies
3/4tracing: Add 'hist:' to hist trigger error log error stringkernel/trace/trace_events_hist.c+2 -10 replies
4/4tracing: Add new testcases for hist trigger parsing errorstools/testing/selftests/ftrace/test.d/trigger/trigger-hist-syntax-errors.tc+32 -04 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMasami Hiramatsu
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] tracing: Improve error messages for histogram sorting

This is v2 of the histogram sorting error message patchset. The code is the same as v1 - this version only adds new Fixes:, Reviewed-by:, and Reported-by: tags.

Text from original post:

Hi,

These patches add some improvements for histogram sorting, addressing some shortcomings pointed out by Masami.

In order to address the specific problem pointed out by Masami, as well as add additional related error messages, the first patch does some simplification of assignment parsing.

The second patch actually adds the new error messages.

The fourth patch adds a new testcase for hist trigger parsing, similar to the same kind of tests for kprobes and uprobes. Additional tests covering all possible hist trigger errors should/will be added here in the future.

The third patch just adds a missing hist: prefix to the error log so that the testcases work properly, and which should have been there anyway.

Thanks,

Tom

The following changes since commit a124692b698b00026a58d89831ceda2331b2e1d0:

ftrace: Enable trampoline when rec count returns back to one (2019-05-25 23:04:43 -0400)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace-hist-sort-err-msgs-v2

Tom Zanussi (4):
tracing: Simplify assignment parsing for hist triggers
tracing: Add hist trigger error messages for sort specification
tracing: Add 'hist:' to hist trigger error log error string
tracing: Add new testcases for hist trigger parsing errors

 kernel/trace/trace_events_hist.c                   | 94 +++++++++++-----------
 .../test.d/trigger/trigger-hist-syntax-errors.tc   | 32 ++++++++
 2 files changed, 78 insertions(+), 48 deletions(-)
 create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-syntax-errors.tc
Signature · 1 line
2.14.1