Skip to content

mptcp: simplify crypto.c

Davide Caratti mptcp 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- add a comment that suggests use of hash to improve performance, thanks to Matthieu
- remove useless #include <tcp.h>, thanks Mat

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: mptcp: remove useless #includes in crypto.cnet/mptcp/crypto.c+0 -40 replies
2/2net: mptcp: randomness improvements for crypto.cnet/mptcp/crypto.c net/mptcp/protocol.c net/mptcp/protocol.h +1 more+19 -1320 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [MPTCP] [PATCH v2 0/2] mptcp: simplify crypto.c

his series wants to simplify, and hopefully improve, random generation of keys and nonces in crypto.c, While at it, I removed some unneeded #includes on top of the file. Any feedbacks are welcome!

Note:
in case you think the code is ok, I will propose to squash it into commit a564283a1e38 ("mptcp: Add key generation and token tree")

Changes since v1:
- add a comment that suggests use of hash to improve performance, thanks to Matthieu
- remove useless #include <tcp.h>, thanks Mat

Changes since RFC:
- use get_random_bytes() instead of siphash, thanks to Florian / Mat

Davide Caratti (2):
net: mptcp: remove useless #includes in crypto.c
net: mptcp: randomness improvements for crypto.c

 net/mptcp/crypto.c   | 76 --------------------------------------------
 net/mptcp/protocol.c |  1 -
 net/mptcp/protocol.h | 24 +++++++-------
 net/mptcp/token.c    | 54 ++++---------------------------
 4 files changed, 19 insertions(+), 136 deletions(-)
Signature · 1 line
2.20.1