Skip to content

sctp: clean up __sctp_connect function

Xin Long linux-sctp netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 3 repliesIn review
  2. v14 patches 15 repliesSuperseded

Changes in v2 from the cover letter

- add the patch 1/5 to avoid a slab-out-of-bounds warning.
- add some code comment for the check change in patch 2/5.
- remove unused 'addrcnt' as Marcelo noticed in patch 3/5.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5sctp: only copy the available addr data in sctp_transport_initnet/sctp/transport.c+1 -11 reply
2/5sctp: check addr_size with sa_family_t size in __sctp_setsockopt_connectxnet/sctp/socket.c+2 -10 replies
3/5sctp: clean up __sctp_connectnet/sctp/socket.c+73 -1360 replies
4/5sctp: factor out sctp_connect_new_asocnet/sctp/socket.c+76 -840 replies
5/5sctp: factor out sctp_connect_add_peernet/sctp/socket.c+31 -450 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarcelo Ricardo Leitner
SeriesA-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCHv2 net-next 0/5] sctp: clean up __sctp_connect function

This patchset is to factor out some common code for sctp_sendmsg_new_asoc() and __sctp_connect() into 2 new functioins.

v1->v2:
- add the patch 1/5 to avoid a slab-out-of-bounds warning.
- add some code comment for the check change in patch 2/5.
- remove unused 'addrcnt' as Marcelo noticed in patch 3/5.

Xin Long (5):
sctp: only copy the available addr data in sctp_transport_init
sctp: check addr_size with sa_family_t size in
__sctp_setsockopt_connectx
sctp: clean up __sctp_connect
sctp: factor out sctp_connect_new_asoc
sctp: factor out sctp_connect_add_peer

 net/sctp/socket.c    | 376 ++++++++++++++++++++-------------------------------
 net/sctp/transport.c |   2 +-
 2 files changed, 147 insertions(+), 231 deletions(-)
Signature · 1 line
2.1.0