Skip to content

btrfs-progs: support xxhash64 checksums

Johannes Thumshirn linux-btrfs 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest posting 2/27 patches 8 repliesIn review
  2. v4 posting 2/212 patches 10 repliesSuperseded
  3. v5 posting 1/24 patches 3 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v3 posting 2/212 patches4 repliesSuperseded
v4 posting 1/24 patches0 repliesSuperseded
v2 posting 2/211 patches12 repliesSuperseded
v3 posting 1/24 patches6 repliesSuperseded
v2 posting 1/24 patches9 repliesSuperseded
v1 RFC4 patches15 repliesSuperseded

Changes in v5 from the cover letter

- Rebased onto latest 'devel' branch and dropped applied changes
- Split 'btrfs-progs: add xxhash64 as checksum algorithm' into several atomic patches
- Changed test code to using 'TEST_ENABLE_OVERRIDE'

Patches in v5 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7btrfs-progs: add option for checksum type to mkfsmkfs/main.c+1 -03 replies
2/7btrfs-progs: add is_valid_csum_type() helpercmds/inspect-dump-super.c+12 -30 replies
3/7btrfs-progs: add table for checksum type and namecmds/inspect-dump-super.c convert/common.c convert/main.c +5 more+50 -300 replies
4/7btrfs-progs: also print checksum type when running mkfsmkfs/main.c+3 -10 replies
5/7btrfs-progs: add xxhash64 to mkfsMakefile cmds/inspect-dump-super.c crypto/hash.c +4 more+38 -25 replies
6/7btrfs-progs: move crc32c implementation to crypto/Android.mk Makefile btrfs-crc.c +20 more+24 -240 replies
7/7btrfs-progs: add test override for mkfs to use different checksumstests/common tests/mkfs-tests/001-basic-profiles/test.sh+15 -31 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/7] btrfs-progs: support xxhash64 checksums

Now that Nikolay's XXHASH64 support for the Crypto API has landed and BTRFS is prepared for an easy addition of new checksums, this patchset implements XXHASH64 as a second, fast but not cryptographically secure checksum hash.

This patchset is fully bisectible and available on github at
https://github.com/morbidrsa/btrfs-progs/tree/mkfs-xxhash64.v5

Changes since v4:
- Rebased onto latest 'devel' branch and dropped applied changes
- Split 'btrfs-progs: add xxhash64 as checksum algorithm' into several atomic patches
- Changed test code to using 'TEST_ENABLE_OVERRIDE'

Johannes Thumshirn (7):
btrfs-progs: add option for checksum type to mkfs
btrfs-progs: add is_valid_csum_type() helper
btrfs-progs: add table for checksum type and name
btrfs-progs: also print checksum type when running mkfs
btrfs-progs: add xxhash64 to mkfs
btrfs-progs: move crc32c implementation to crypto/
btrfs-progs: add test override for mkfs to use different checksums

 Android.mk                                  |  4 ++--
 Makefile                                    |  7 ++++---
 btrfs-crc.c                                 |  2 +-
 btrfs-find-root.c                           |  2 +-
 btrfs-sb-mod.c                              |  2 +-
 btrfs.c                                     |  2 +-
 cmds/inspect-dump-super.c                   | 26 ++++++++++++++++----------
 cmds/rescue-chunk-recover.c                 |  2 +-
 cmds/rescue-super-recover.c                 |  2 +-
 common/utils.c                              |  2 +-
 convert/common.c                            |  2 +-
 convert/main.c                              |  6 +++---
 {kernel-lib => crypto}/crc32c.c             |  2 +-
 {kernel-lib => crypto}/crc32c.h             |  0
 crypto/hash.c                               | 17 +++++++++++++++++
 crypto/hash.h                               | 10 ++++++++++
 ctree.c                                     | 28 ++++++++++++++++++++++++++++
 ctree.h                                     | 18 +++++++-----------
 disk-io.c                                   |  9 ++++++---
 extent-tree.c                               |  2 +-
 file-item.c                                 |  2 +-
 free-space-cache.c                          |  2 +-
 hash.h                                      |  2 +-
 image/main.c                                |  7 ++++---
 image/sanitize.c                            |  2 +-
 library-test.c                              |  2 +-
 mkfs/common.c                               | 14 +++++++-------
 mkfs/main.c                                 | 10 ++++++++--
 send-stream.c                               |  2 +-
 tests/common                                | 10 ++++++++--
 tests/mkfs-tests/001-basic-profiles/test.sh |  8 +++++++-
 31 files changed, 143 insertions(+), 63 deletions(-)
 rename {kernel-lib => crypto}/crc32c.c (99%)
 rename {kernel-lib => crypto}/crc32c.h (100%)
 create mode 100644 crypto/hash.c
 create mode 100644 crypto/hash.h
Signature · 1 line
2.16.4